Update gecko.readthedocs links to the new firefox-source-docs.mozilla.org location

RESOLVED FIXED in Firefox 57



2 years ago
2 years ago


(Reporter: chutten, Assigned: kausam2015, Mentored)



Firefox Tracking Flags

(firefox57 fixed)


(Whiteboard: [good first bug][lang=rst][lang=js][lang=c++][lang=java])


(1 attachment, 2 obsolete attachments)

13.21 KB, patch
: review+
Details | Diff | Splinter Review


2 years ago
According to searchfox there are 15 remaining links in mozilla-central that are pointing at gecko.readthedocs.io: http://searchfox.org/mozilla-central/search?q=gecko.readthedocs&path=

gecko.readthedocs.io is no longer being updated (firefox source docs having exceeded the size limits of readthedocs). We are instead now hosting it on a domain mozilla controls at firefox-source-docs.mozilla.org

This bug is about changing those gecko.readthedocs.io links in the source tree to point to their new locations somewhere within firefox-source-docs.mozilla.org

This might not simply be a substitution of firefox-source-docs.mozilla.org for gecko.readthedocs.io as ReadTheDocs had "en/latest" in a lot of links and firefox-source-docs.mozilla.org doesn't.

Be sure to test the new links to make sure they point at valid locations.


2 years ago
Mentor: chutten

Comment 1

2 years ago
Where  can I access the files because I am new to this field could you please help me?
also Where to start?

Comment 2

2 years ago
I am working on this bug.

Comment 3

2 years ago
Posted patch patchfile (obsolete) — Splinter Review
Attachment #8903989 - Flags: review?(chutten)
Comment on attachment 8903989 [details] [diff] [review]

Review of attachment 8903989 [details] [diff] [review]:

This looks good, thanks!
There are only some minor trailing spaces that need to be removed before we can proceed.

Note that the standard commit message convention is "Bug XXX - ..." (vs. your "Bug XXX: ...").

::: mobile/android/base/java/org/mozilla/gecko/telemetry/TelemetryBackgroundReceiver.java
@@ +38,4 @@
>  /**
>   * Receives and processes telemetry broadcasts from background services, namely Sync.
>   * Nomenclature:
> + * - Bundled Sync Ping: a Sync Ping as documented at https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/sync-ping.html 

There is a trailing space here on this line, please remove it.

::: mobile/android/base/java/org/mozilla/gecko/telemetry/pingbuilders/TelemetryCorePingBuilder.java
@@ +36,4 @@
>  /**
>   * Builds a {@link TelemetryOutgoingPing} representing a core ping.
>   *
> + * See https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/core-ping.html 

There is a trailing space here on this line, please remove it.

::: mobile/android/base/java/org/mozilla/gecko/telemetry/pingbuilders/TelemetrySyncPingBundleBuilder.java
@@ +26,4 @@
>  /**
>   * Responsible for building a Sync Ping, based on the telemetry docs:
> + * https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/sync-ping.html 

More trailing space.
Attachment #8903989 - Flags: review?(chutten) → feedback+
Assignee: nobody → kausam2015
Priority: -- → P2

Comment 5

2 years ago
Posted patch patchfile.patch (obsolete) — Splinter Review
Attachment #8904321 - Flags: review?(gfritzsche)

Comment 6

2 years ago
(In reply to Cosm from comment #2)
> I am working on this bug.

Sorry I am Totaly new to it
Could help me in finding where should I start ?
Comment on attachment 8904321 [details] [diff] [review]

Chris is back today, so i'm moving this review over to him.
Attachment #8904321 - Flags: review?(gfritzsche) → review?(chutten)
(In reply to ppaswanth3 from comment #6)
> (In reply to Cosm from comment #2)
> > I am working on this bug.
> Sorry I am Totaly new to it
> Could help me in finding where should I start ?

I think this is not the best medium to help you get started.
Please see the information over here, it gets you started and points you to chat and other forms of getting help:

Comment 9

2 years ago
Comment on attachment 8904321 [details] [diff] [review]

Review of attachment 8904321 [details] [diff] [review]:

Good work! Fix the one link and put r=chutten on the end of the first line of your commit message (a la https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#Commit_Message_Conventions ), reupload it to this bug, and we'll be ready to get this code submitted.

::: devtools/docs/frontend/telemetry.md
@@ +38,4 @@
>  New data types have been added over the years, so it's quite feasible that some of our probes are not the most suitable nowadays.
> +There's more information about types (and telemetry in general) on [this page](https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe) and [this other page](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/index.html).

The second link should be https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/index.html
Attachment #8904321 - Flags: review?(chutten) → review+

Comment 10

2 years ago
Posted patch patchfileSplinter Review
Thank you Chris, for the pointing out the correction.
Attachment #8903989 - Attachment is obsolete: true
Attachment #8904321 - Attachment is obsolete: true
Attachment #8904633 - Flags: review?(chutten)


2 years ago
Attachment #8904633 - Flags: review?(chutten) → review+

Comment 11

2 years ago
I have marked this bug for checkin, so your code should reach the tree shortly and then be included in either tomorrow's or the next day's Nightly build of Firefox. Congratulations!

Do you need any help finding another patch to work on, or would you like to run through the list on Bugs Ahoy (https://www.joshmatthews.net/bugsahoy/?internals=1) to find something you find interesting?
Keywords: checkin-needed

Comment 12

2 years ago
Pushed by ryanvm@gmail.com:
Update gecko.readthedocs links to the new firefox-source-docs.mozilla.org location. r=chutten
Keywords: checkin-needed
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.