1395979 - Remove backdrop hack in GetLayoutParentStyleForOutOfFlow

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

This was apparently added back when this function was called nsPlaceholderFrame::GetParentStyleContext, which was back when placeholders had style contexts parented to something.  Now that placeholders are non-inheriting, we don't need this code anymore.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove backdrop hackery from placeholder's GetLayoutParentStyleForOutOfFlow

This was never even meant to apply to the out-of-flow, just to the placeholder
itself.  So it's been effectively dead since placeholders stopped inheriting
from another style context.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8903625 [details] [diff] [review]
Remove backdrop hackery from placeholder's GetLayoutParentStyleForOutOfFlow

Review of attachment 8903625 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsPlaceholderFrame.cpp
@@ +208,5 @@
>  
>  nsStyleContext*
>  nsPlaceholderFrame::GetLayoutParentStyleForOutOfFlow(nsIFrame** aProviderFrame) const
>  {
>    nsIFrame* parentFrame = GetParent();

You can now replace the only use of parentFrame below with GetParent() directly, so that this variable is no longer needed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4e4b2b783d
Remove backdrop hackery from placeholder's GetLayoutParentStyleForOutOfFlow.  r=xidorn

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb4e4b2b783d