Closed
Bug 1396057
Opened 8 years ago
Closed 7 years ago
stylo: Bring back calc support inside media queries
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: canova, Assigned: emilio)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
This was implemented in stylo but not in gecko. We had to temporarily disable this just in case in Bug 1390339. We should bring this support back and ship that in the next release. See Bug 1390339 comment #10.
It's not blocking stylo.
Updated•8 years ago
|
Priority: -- → P4
Updated•8 years ago
|
status-firefox57:
--- → wontfix
Assignee | ||
Comment 1•7 years ago
|
||
I was dealing with bug 1408308 and it'd be nice to update media query parsing to the spec.
Assignee: nobody → emilio
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
(This is just the first step in updating to the spec, we should add support for proper expressions in another bug)
Assignee | ||
Comment 6•7 years ago
|
||
This needs the following expectations update:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c2b7db9bd35452ead7acc1dfc3aa0c1f9cfeb8e
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8927356 [details]
Bug 1396057: Fix indentation of the media query code.
Xidorn and Cam are on PTO. Manish, could you review this?
Attachment #8927356 -
Flags: review?(xidorn+moz) → review?(manishearth)
Assignee | ||
Updated•7 years ago
|
Attachment #8927357 -
Flags: review?(xidorn+moz) → review?(manishearth)
Assignee | ||
Updated•7 years ago
|
Attachment #8927358 -
Flags: review?(xidorn+moz) → review?(manishearth)
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8927356 [details]
Bug 1396057: Fix indentation of the media query code.
https://reviewboard.mozilla.org/r/198664/#review203960
I think this style change is very subjective, but whatever. The new style seems to be what rustfmt does so that seems ok.
Attachment #8927356 -
Flags: review?(manishearth) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8927357 [details]
Bug 1396057: Fix evaluation of rem inside media queries.
https://reviewboard.mozilla.org/r/198666/#review203962
Attachment #8927357 -
Flags: review?(manishearth) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8927358 [details]
Bug 1396057: Support calc() in media queries.
https://reviewboard.mozilla.org/r/198668/#review203964
Attachment #8927358 -
Flags: review?(manishearth) → review+
Comment 11•7 years ago
|
||
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6bed71583aa9
Change tests of calc in media-queries so that the root element style has been resolved first. r=Manishearth
https://hg.mozilla.org/integration/autoland/rev/47752e9824da
Update test expectations. r=me
Assignee | ||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Does the web developer documentation need to be updated to account for these changes by any chance?
![]() |
||
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6bed71583aa9
https://hg.mozilla.org/mozilla-central/rev/47752e9824da
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment 17•7 years ago
|
||
(In reply to Ryan Jones [:sciguyryan] from comment #13)
> Does the web developer documentation need to be updated to account for these
> changes by any chance?
Probably, yes.
Keywords: dev-doc-needed
Comment 18•7 years ago
|
||
Documented:
* Adding in note about it to browser compat data: https://github.com/mdn/browser-compat-data/pull/886
* Note in Fx59 rel notes: https://developer.mozilla.org/en-US/Firefox/Releases/59#CSS
Let me know if this looks OK. Thanks!
Flags: needinfo?(emilio)
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 19•7 years ago
|
||
I don't think it's worth mentioning that calc() in media queries was disabled on stylo, since stylo was never shipped before 57, and Gecko never supported it.
Other than that it looks good!
Flags: needinfo?(emilio)
Comment 20•7 years ago
|
||
(In reply to Emilio Cobos Álvarez [:emilio] from comment #19)
> I don't think it's worth mentioning that calc() in media queries was
> disabled on stylo, since stylo was never shipped before 57, and Gecko never
> supported it.
>
> Other than that it looks good!
OK; I've simplified this note to just say it was adding in 59. The calc() compat data contains the exact info.
You need to log in
before you can comment on or make changes to this bug.
Description
•