Closed Bug 1396106 Opened 8 years ago Closed 8 years ago

Edits to "scheduled changes" are not auto signed-off

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rehandalal+mozilla, Assigned: ichiato.ikikin)

References

Details

(Whiteboard: [lang=python][ready])

When I create a scheduled change the system automatically assigns my sign off to the scheduled change. If for some reason I have to edit the scheduled change it revokes that sign off and I have to manually sign off on the edit that I have made. I think given that I am still the one making the edit it should re-sign off on the subsequent change that I have made.
Good find. Probably a pretty easy fix. The auto-signoff on creation happens here: https://github.com/mozilla/balrog/blob/fc1892df1196f732bf7b6ca5bc4b4bd6d56d5c3d/auslib/db.py#L1137 The auto-revoke happens here: https://github.com/mozilla/balrog/blob/fc1892df1196f732bf7b6ca5bc4b4bd6d56d5c3d/auslib/db.py#L1196 We probably need to add the auto-signoff code after the auto-revoke.
Component: Balrog: Frontend → Balrog: Backend
Whiteboard: [lang=python][ready]
Mentor: bhearsum
Priority: -- → P1
Mentor: bhearsum
Assignee: nobody → ichiato.ikikin
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/a994adddb16160908a06053daceb56bd9cc6a77d Bug 1396106: Edits to "scheduled changes" are not auto signed-off (#422). r=bhearsum,allan-silva
This is in production - thank you ichiato!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.