[a11y] Android's focus highlight is displaying offset when focusing page contents

RESOLVED FIXED in Firefox 56

Status

()

defect
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: rbarker)

Tracking

Trunk
Firefox 57
All
Android
Points:
---

Firefox Tracking Flags

(fennec+, firefox55 wontfix, firefox56 verified, firefox57 verified)

Details

Attachments

(2 attachments)

While playing around with Talkback, I've noticed that when putting the focus on page contents, two focus highlights are visible: a green one provided by Android, and an orange one that is presumably provided by Gecko (compare screenshot).

At a guess we're forgetting to handle the toolbar height somewhere.

Nightly is definitively affected and so is Release, so I'm guessing that things aren't any better on Beta, either.
Randall might have broken this with the toolbar rewrite, so he'll take a look.
Assignee: nobody → rbarker
tracking-fennec: ? → +
Priority: -- → P2
Comment on attachment 8905688 [details]
Bug 1396233 - Add toolbar offset to screen location of a11y event so Android can draw the target box in the correct location

https://reviewboard.mozilla.org/r/177484/#review182536
Attachment #8905688 - Flags: review?(esawin) → review+
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/036f4ab0f2e9
Add toolbar offset to screen location of a11y event so Android can draw the target box in the correct location r=esawin
https://hg.mozilla.org/mozilla-central/rev/036f4ab0f2e9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Please request Beta approval on this when you get a chance.
Flags: needinfo?(rbarker)
Comment on attachment 8905688 [details]
Bug 1396233 - Add toolbar offset to screen location of a11y event so Android can draw the target box in the correct location

Approval Request Comment
[Feature/Bug causing the regression]: Dynamic Toolbar v3
[User impact if declined]: The android generated hit targets are in the wrong location for Talk Back
[Is this code covered by automated tests?]:no
[Has the fix been verified in Nightly?]:no
[Needs manual test from QE? If yes, steps to reproduce]:no 
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:no
[Why is the change risky/not risky?]:it only adds the offset of the toolbar to the a11y event generated for android to support talkback on webpages.
[String changes made/needed]:none
Flags: needinfo?(rbarker)
Attachment #8905688 - Flags: approval-mozilla-beta?
Comment on attachment 8905688 [details]
Bug 1396233 - Add toolbar offset to screen location of a11y event so Android can draw the target box in the correct location

Fix the toolbar offset issue. Beta56+.
Attachment #8905688 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on the latest Beta build 56.0b13
This issue was tested on a nexus 6P (Android 8.0)
Also verified as fixed on the latest Nightly build 57.0a1 (2017.09.19)
You need to log in before you can comment on or make changes to this bug.