139624 - View Source menu has redundant item, missing access key

Status: VERIFIED FIXED

(Core Graveyard :: View Source, defect)

Description

[Greg Valure]

View Source | Wrap Long Lines doesn't update its checkmark when toggled, nor
does it have an access key.  The patch fixes this.

2002-04-17-11 Win98 (1.0 RC 1)

Comment 1

[Greg Valure]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

agreed on the accesskey issue, but the check updates correctly here (linux
2002-04-22-07 trunk build).  How do I reproduce the "check not updating" problem?

Comment 3

[Greg Valure]

Okay, I figured it out.  The checkmark will toggle if you click the menu item
with the mouse, but not if you select it with the keyboard, either by
arrows+enter or accesskey.

Trying this with some other menus shows that it's a more general issue and not a
View Source issue.  For example, in the Manage Bookmarks window, View | Toolbar
and View | Show Columns | Keyword work correctly via keyboard, but View | Show
Columns | Location does not.  I don't know what the difference is.  Anyway, I
think this is bug 96229.

Comment 4

[Greg Valure]

Retargeting bug then, since the checkbox issue is separate, and I found another
problem with the menu anyway.  We have a redundant New Navigator Window item,
which makes the menu look like this:

New Navigator Window
New >
   Navigator Window
   Composer Page

Since other menus are using the New submenu, the top-level one should go.  The
Ctrl+N shortcut still works without it.

Comment 5

[Greg Valure]

Attachment: Updated Patch

Updated patch.	Drops the JavaScript changes and removes the redundant menu
item.

Comment 6

[Greg Valure]

...the patch still defines the access key, too.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 80735 [details] [diff] [review]
Updated Patch

r=bzbarsky; get ben or blake to sr.

Comment 8

[Alec Flett]

Comment on attachment 80735 [details] [diff] [review]
Updated Patch

sr=alecf

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in on the trunk, leaving open in case Greg wants to try to get this on
the branch.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 80735 [details] [diff] [review]
Updated Patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 11

[Boris Zbarsky [:bzbarsky]]

Checked in on the branch, marking fixed.  Thanks for the patch, Greg!

Comment 12

[Patty Mac]

Verified on all platforms (netscape branch build: 2002-07-17-08-1.0.0)