Move selectGrid test helper method to head.js

NEW
Unassigned

Status

P5
normal
a year ago
2 months ago

People

(Reporter: micah, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified

Firefox Tracking Flags

(firefox57 fix-optional)

Details

(Reporter)

Description

a year ago
function* selectGrid(gridIndex, gridList, highlighters, store) {
  let gridCheckBox = gridList.children[gridIndex].querySelector("input");
  let onHighlighterShown = highlighters.once("grid-highlighter-shown");
  let onGridCheckboxChange = waitUntilState(store, state =>

    state.grids[gridIndex].highlighted);

  gridCheckBox.click();

  yield onHighlighterShown;

  yield onGridCheckboxChange;

}

We should move this method created in grids/test/browser_grids_grid-outline-scroll-into-view-of-grid to the head.js file of the grid test folder. Moreover, we should change the code using the same logic in the existing tests to use this method.
status-firefox57: --- → fix-optional

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.