Open
Bug 1396339
Opened 8 years ago
Updated 3 years ago
Move selectGrid test helper method to head.js
Categories
(DevTools :: Inspector, enhancement, P5)
DevTools
Inspector
Tracking
(firefox57 fix-optional)
NEW
Tracking | Status | |
---|---|---|
firefox57 | --- | fix-optional |
People
(Reporter: micah, Unassigned)
References
(Blocks 1 open bug)
Details
function* selectGrid(gridIndex, gridList, highlighters, store) {
let gridCheckBox = gridList.children[gridIndex].querySelector("input");
let onHighlighterShown = highlighters.once("grid-highlighter-shown");
let onGridCheckboxChange = waitUntilState(store, state =>
state.grids[gridIndex].highlighted);
gridCheckBox.click();
yield onHighlighterShown;
yield onGridCheckboxChange;
}
We should move this method created in grids/test/browser_grids_grid-outline-scroll-into-view-of-grid to the head.js file of the grid test folder. Moreover, we should change the code using the same logic in the existing tests to use this method.
Updated•8 years ago
|
Priority: -- → P5
Updated•8 years ago
|
status-firefox57:
--- → fix-optional
Updated•7 years ago
|
Product: Firefox → DevTools
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•