[lint] Settings follow-up: setView does not support all versions

RESOLVED FIXED in Firefox 57

Status

()

Firefox for Android
General
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: liuche, Assigned: liuche)

Tracking

Trunk
Firefox 57
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Fix lint errors from bug 1386735 - inflate layout instead of using resource id directly, to support Android versions below r21.
Comment hidden (mozreview-request)
Assignee: nobody → liuche
Iteration: --- → 1.29
Whiteboard: [MobileAS]
(Assignee)

Comment 2

11 months ago
mozreview-review
Comment on attachment 8904056 [details]
Bug 1396407 - [lint] Fix AlertDialog.Builder.setView call to support pre-r21.

https://reviewboard.mozilla.org/r/175800/#review180776

Quick linter fix - inflate resource instead of just passing in resid. r=trivial
Attachment #8904056 - Flags: review?(liuche) → review+

Comment 3

11 months ago
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d3f96564e3e
[lint] Fix AlertDialog.Builder.setView call to support pre-r21. r=liuche
Thank you for the quick action. Unfortunately, the lint job is still failing: https://treeherder.mozilla.org/logviewer.html#?job_id=128119255&repo=autoland
Flags: needinfo?(liuche)
https://hg.mozilla.org/mozilla-central/rev/3d3f96564e3e
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Depends on: 1396589
Thanks Sebastian, I forgot to remove the line that was causing the lint failure - removed it in bug 1396589.
Flags: needinfo?(liuche)
You need to log in before you can comment on or make changes to this bug.