1396451 - [skiplist] add mozilla::detail::MutexImpl::lock to prefixSignatureRegEx

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Nicholas Nethercote [inactive]]

https://crash-stats.mozilla.com/report/index/3ba061cd-d9fa-4b61-81a7-7ef430170903 has this signature:

> [@ pthread_mutex_lock | mozilla::detail::MutexImpl::lock ]

We should skip past the second entry to get an additional stack frame.

Adrian, would you mind taking this? I'm flat out working on Stylo stuff for Firefox 57 right now.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

I'm not working on Socorro anymore, passing this along to Will.

Comment 2

[Andrew McCreight [:mccr8]]

I can take this. I have another thing I want to add to the prefix list.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Thank you, Andrew!

Comment 4

[Andrew McCreight [:mccr8]]

I added mozilla::detail::MutexImpl::.* to get both lock and unlock.

Comment 5

[Andrew McCreight [:mccr8]]

https://github.com/mozilla-services/socorro/pull/3958

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/16d2cd21229c7d22c6fbdeaf16f532aeb115ae02
Bug 1396451 - Add mozilla::detail::MutexImpl::.* to prefix list. (#3958)

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

https://crash-stats.mozilla.com/report/index/3ba061cd-d9fa-4b61-81a7-7ef430170903

old: pthread_mutex_lock | mozilla::detail::MutexImpl::lock
new: pthread_mutex_lock | mozilla::detail::MutexImpl::lock | mozilla::net::CacheIOThread::QueueSize

Andrew, Nicholas: Does that look better?

Comment 8

[Andrew McCreight [:mccr8]]

Yes, thanks.

Comment 9

[Nicholas Nethercote [inactive]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #7)
> https://crash-stats.mozilla.com/report/index/3ba061cd-d9fa-4b61-81a7-
> 7ef430170903
> 
> old: pthread_mutex_lock | mozilla::detail::MutexImpl::lock
> new: pthread_mutex_lock | mozilla::detail::MutexImpl::lock |
> mozilla::net::CacheIOThread::QueueSize

That's the signature I want, yes :)

But the crash report you linked to still has the old signature. Is that expected?

Comment 10

[Andrew McCreight [:mccr8]]

(In reply to Nicholas Nethercote [:njn] from comment #9)
> But the crash report you linked to still has the old signature. Is that
> expected?

Yes, it is expected. The updated lists have to get rolled out to production (which I think hasn't happened yet), and then you'd have to manually reprocess an old crash report to get the new signature.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--I meant to use the -stage link:

https://crash-stats.allizom.org/report/index/3ba061cd-d9fa-4b61-81a7-7ef430170903

We just did a -prod push a few hours ago, so that code is now in -prod. Someone will have to reprocess the old crashes in order to pick up the new signature.

Comment 12

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--forgot to mark this FIXED.