1396472 - Signing errors for Fennec 56.0b9

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Affects all multi and single locale builds, eg https://public-artifacts.taskcluster.net/ZXdZAznCSh-55ZenYWYIYQ/0/public/logs/chain_of_trust.log

Fallout from bug 1384482 ?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Error message:

2017-09-04T03:12:28     INFO - build_task_dependencies signing ZXdZAznCSh-55ZenYWYIYQ
2017-09-04T03:12:28     INFO - find_sorted_task_dependencies signing ZXdZAznCSh-55ZenYWYIYQ
2017-09-04T03:12:28     INFO - found dependencies: [('signing:decision', 'dkTyxu_OT6auOGjYNGpS_g'), ('signing:build', 'M1BGkzwmQnWoTeGxSpas8Q')]
2017-09-04T03:12:28    DEBUG -  signing:decision dkTyxu_OT6auOGjYNGpS_g is docker-worker
2017-09-04T03:12:28     INFO - build_task_dependencies signing:decision dkTyxu_OT6auOGjYNGpS_g
2017-09-04T03:12:28     INFO - find_sorted_task_dependencies signing:decision dkTyxu_OT6auOGjYNGpS_g
2017-09-04T03:12:28     INFO - found dependencies: [('signing:decision:decision', 'cZl-gqPpRwi7i70380hMxg')]
2017-09-04T03:12:29 CRITICAL - Chain of Trust verification error!
Traceback (most recent call last):
  File "/builds/scriptworker/lib/python3.5/site-packages/scriptworker/cot/verify.py", line 581, in build_task_dependencies
    task_defn = await chain.context.queue.task(task_id)
  File "/builds/scriptworker/lib/python3.5/site-packages/taskcluster/async/queue.py", line 44, in task
    return await self._makeApiCall(self.funcinfo["task"], *args, **kwargs)
  File "/builds/scriptworker/lib/python3.5/site-packages/taskcluster/async/asyncclient.py", line 76, in _makeApiCall
    return await self._makeHttpRequest(entry['method'], route, payload)
  File "/builds/scriptworker/lib/python3.5/site-packages/taskcluster/async/asyncclient.py", line 189, in _makeHttpRequest
    superExc=None
taskcluster.exceptions.TaskclusterRestFailure: cZl-gqPpRwi7i70380hMxg does not correspond to a task that exists.
Are you sure this task has already been submitted?
----
method:     task
errorCode:  ResourceNotFound
statusCode: 404
time:       2017-09-04T03:12:29.169Z

Comment 2

[Johan Lorenzo [:jlorenzo]]

It's more a fallout of bug 1259627, I think. The content of dependencies field changed in this bug. Chain of Trust now looks for a decision task that matches the task group Id of graph one. 

We should attach the task group Id of graph 1 (cZl-gqPpRwi7i70380hMxg in the previous example) to "fennec mozilla-beta atomic submission task" (W9dCWdXdQdShK0b-vbcVLg), instead of generating a new task Id.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: releasetasks PR

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8904132 [details] [review]
releasetasks PR



I was a bit concerned about this change but :jlorenzo has valid arguments.

The decision task in this case will be an actual task which will both serve as a) taskGroupId for all tasks in the graph b) direct dependency for all tasks that don't normally have any other dependency.

This is what happens on nightlies as well.
See example at https://tools.taskcluster.net/groups/aylDrROKT2aHrO5WsleD0g/tasks/BrdTe0jxQg2dCc3fNRv2Jg/details

Comment 5

[Johan Lorenzo [:jlorenzo]]

The decision task now matches the task group Id. However Chain Of Trust remain unhappy. Let's track this in bug 1396517.