1396477 - The speech bubble box-shadow in RTL is incorrect

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[[e-mail]]

The shadow is still at left instead of at right side in RTL mode.

step to reproduce:

* when onboarding speech bubble is shown
* open devtool inspector and change `body dir="ltr"` to `body dir="rtl"`

expect:

The shadow of speech bubble is at right side in RTL mode.

Comment 1

[[e-mail]]

should do after bug 1392472 land since it includes `onboarding-overlay-button::after` style change

Comment 2

[[e-mail]]

Attachment: Bug 1396477 - fix the onboarding speech bubble box-shadow in RTL;

Review commit: https://reviewboard.mozilla.org/r/176634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176634/

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8904859 [details]
Bug 1396477 - fix the onboarding speech bubble box-shadow in RTL;

https://reviewboard.mozilla.org/r/176634/#review181698

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d9dde6b07c4
fix the onboarding speech bubble box-shadow in RTL;r=rexboy

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7d9dde6b07c4

Comment 6

[Justin [:JW_SoftvisionQA]]

I have verified that this issue is no longer reproducible on Win 10 x64, Win 7 x86, Mac 10.13, & Ubuntu 16.04 x32 with Firefox 58.

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm the intended behavior is respected on beta. I verified using Fx 57.0b7 on Windows 10 x64, Ubuntu 14.04 LTS and macOS X 10.12.6.