1396571 - [dt-addon] m-c code should not retrieve DevTools preferences without using a default value

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

After devtools move to a system addon, they won't be available by default in xpc-shell tests.

> if (Services.prefs.getBoolPref("devtools.webconsole.persistlog")) {

This throws in various xpc-shell tests if devtools is moved to a system addon.

Comment 1

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

Attachment: Bug 1396571 - use default value when retrieving pref devtools.webconsole.persistlog;

Review commit: https://reviewboard.mozilla.org/r/176020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176020/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8904240 [details]
Bug 1396571 - use default value when retrieving pref devtools.webconsole.persistlog;

https://reviewboard.mozilla.org/r/176020/#review181054

LGTM!

Honza

Comment 3

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

Thanks for the review Honza, landing!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e5269790022
use default value when retrieving pref devtools.webconsole.persistlog;r=Honza

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6e5269790022