Closed Bug 1396571 Opened 7 years ago Closed 7 years ago

[dt-addon] m-c code should not retrieve DevTools preferences without using a default value

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

After devtools move to a system addon, they won't be available by default in xpc-shell tests.

> if (Services.prefs.getBoolPref("devtools.webconsole.persistlog")) {

This throws in various xpc-shell tests if devtools is moved to a system addon.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8904240 [details]
Bug 1396571 - use default value when retrieving pref devtools.webconsole.persistlog;

https://reviewboard.mozilla.org/r/176020/#review181054

LGTM!

Honza
Attachment #8904240 - Flags: review?(odvarko) → review+
Thanks for the review Honza, landing!
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e5269790022
use default value when retrieving pref devtools.webconsole.persistlog;r=Honza
https://hg.mozilla.org/mozilla-central/rev/6e5269790022
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.