1396601 - Remove MOZ_ENABLE_CONTENTACTION

Status: RESOLVED FIXED

(Firefox :: File Handling, enhancement, P3)

Description

[Gian-Carlo Pascutto [:gcp]]

While debugging bug 1382323 I ran into MOZ_ENABLE_CONTENTACTION. It looks like this is Meego specific stuff, and can be removed.

Comment 1

[Swapnil P (:DarthSwap)]

Hi! I would like to work on this bug. Could you please post any resources that could help me get started?

Comment 2

[Swapnil P (:DarthSwap)]

I did a grep on the entire mozilla central source code and found MOZ_ENABLE_CONTENTACTION in:
- xpcom/io/nsLocalFileUnix.cpp
- uriloader/exthandler/moz.build
- uriloader/exthandler/unix/nsMIMEInfoUnix.h
- uriloader/exthandler/unix/nsMIMEInfoUnix.cpp

Is the fix of this bug to remove MOZ_ENABLE_CONTENTACTION and the code depending on it from these files?

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Yes. Basically nothing we support uses MOZ_ENABLE_CONTENTACTION any more, so all code inside any #ifdef for it can be removed, and the support for it in the moz.build files can be removed as well.

Comment 4

[Swapnil P (:DarthSwap)]

Attachment: Bug1396601.patch

Have removed MOZ_ENABLE_CONTENTACTION from the .cpp files and from moz.build.

Comment 5

[:Paolo Amadini]

Comment on attachment 8937231 [details] [diff] [review]
Bug1396601.patch

Thanks for the patch! There are more code instances to remove:

https://dxr.mozilla.org/mozilla-central/search?q=MOZ_ENABLE_CONTENTACTION

Also, nsContentHandlerApp.cpp has to be removed from version control.

Comment 6

[Swapnil P (:DarthSwap)]

Attachment: Bug1396601.patch Removed all instances of MOZ_ENABLE_CONTENTACTION. r=paolo

I have removed all the mentioned instances from the stated files as well. I have also removed nsContentHandlerApp.cpp.

I apologize for being late, I could not work on the bug sooner due to end of year holidays.

Comment 7

[:Paolo Amadini]

Comment on attachment 8939376 [details] [diff] [review]
Bug1396601.patch Removed all instances of MOZ_ENABLE_CONTENTACTION. r=paolo

(In reply to Swapnil from comment #6)
> I have removed all the mentioned instances from the stated files as well. I
> have also removed nsContentHandlerApp.cpp.

The removal of nsContentHandlerApp.cpp didn't make it to the patch, this may need an "hg rm" or "hg addremove". Can you post an updated patch? It will be a fast review then.

> I apologize for being late, I could not work on the bug sooner due to end of
> year holidays.

Thank you, but don't worry, this isn't urgent!

Comment 8

[Swapnil P (:DarthSwap)]

Attachment: Bug1396601.patch

I did not know about hg rm. I have done hg rm on nsContentHandlerApp.cpp. Please review. Thanks!

Comment 9

[:Paolo Amadini]

Comment on attachment 8940796 [details] [diff] [review]
Bug1396601.patch

Thank you! I started a tryserver build with your changes here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b5c75f6645814a825ca1ea3c5a8a2cdffbb6538

I've kept the commit message from the original patch because intermediate patch revisions are not checked in, so the message doesn't need to reference them or refer to review comments.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aabf5fcec100
Removed all instances of MOZ_ENABLE_CONTENTACTION from .cpp files and moz.build file. r=paolo

Comment 11

[:Paolo Amadini]

I have pushed the changeset to the mozilla-inbound tree, it will be integrated with mozilla-central soon.

Thanks for your contribution!

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/aabf5fcec100