Remove MOZ_ENABLE_CONTENTACTION

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
RESOLVED FIXED
a year ago
26 days ago

People

(Reporter: gcp, Assigned: DarthSwap)

Tracking

unspecified
Firefox 59
ARM
Other
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox59 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

a year ago
While debugging bug 1382323 I ran into MOZ_ENABLE_CONTENTACTION. It looks like this is Meego specific stuff, and can be removed.
status-firefox57: --- → fix-optional

Updated

a year ago
Priority: -- → P3
Whiteboard: [good first bug]
(Assignee)

Comment 1

10 months ago
Hi! I would like to work on this bug. Could you please post any resources that could help me get started?
(Assignee)

Comment 2

10 months ago
I did a grep on the entire mozilla central source code and found MOZ_ENABLE_CONTENTACTION in:
- xpcom/io/nsLocalFileUnix.cpp
- uriloader/exthandler/moz.build
- uriloader/exthandler/unix/nsMIMEInfoUnix.h
- uriloader/exthandler/unix/nsMIMEInfoUnix.cpp

Is the fix of this bug to remove MOZ_ENABLE_CONTENTACTION and the code depending on it from these files?
(Reporter)

Comment 3

10 months ago
Yes. Basically nothing we support uses MOZ_ENABLE_CONTENTACTION any more, so all code inside any #ifdef for it can be removed, and the support for it in the moz.build files can be removed as well.
(Assignee)

Comment 4

10 months ago
Created attachment 8937231 [details] [diff] [review]
Bug1396601.patch

Have removed MOZ_ENABLE_CONTENTACTION from the .cpp files and from moz.build.
Attachment #8937231 - Flags: review?(paolo.mozmail)

Comment 5

10 months ago
Comment on attachment 8937231 [details] [diff] [review]
Bug1396601.patch

Thanks for the patch! There are more code instances to remove:

https://dxr.mozilla.org/mozilla-central/search?q=MOZ_ENABLE_CONTENTACTION

Also, nsContentHandlerApp.cpp has to be removed from version control.
Attachment #8937231 - Flags: review?(paolo.mozmail)
(Assignee)

Comment 6

10 months ago
Created attachment 8939376 [details] [diff] [review]
Bug1396601.patch Removed all instances of MOZ_ENABLE_CONTENTACTION. r=paolo

I have removed all the mentioned instances from the stated files as well. I have also removed nsContentHandlerApp.cpp.

I apologize for being late, I could not work on the bug sooner due to end of year holidays.
Attachment #8937231 - Attachment is obsolete: true
Attachment #8939376 - Flags: review?(paolo.mozmail)

Comment 7

9 months ago
Comment on attachment 8939376 [details] [diff] [review]
Bug1396601.patch Removed all instances of MOZ_ENABLE_CONTENTACTION. r=paolo

(In reply to Swapnil from comment #6)
> I have removed all the mentioned instances from the stated files as well. I
> have also removed nsContentHandlerApp.cpp.

The removal of nsContentHandlerApp.cpp didn't make it to the patch, this may need an "hg rm" or "hg addremove". Can you post an updated patch? It will be a fast review then.

> I apologize for being late, I could not work on the bug sooner due to end of
> year holidays.

Thank you, but don't worry, this isn't urgent!
Attachment #8939376 - Flags: review?(paolo.mozmail)
(Assignee)

Comment 8

9 months ago
Created attachment 8940796 [details] [diff] [review]
Bug1396601.patch

I did not know about hg rm. I have done hg rm on nsContentHandlerApp.cpp. Please review. Thanks!
Attachment #8939376 - Attachment is obsolete: true
Attachment #8940796 - Flags: review?(paolo.mozmail)

Comment 9

9 months ago
Comment on attachment 8940796 [details] [diff] [review]
Bug1396601.patch

Thank you! I started a tryserver build with your changes here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b5c75f6645814a825ca1ea3c5a8a2cdffbb6538

I've kept the commit message from the original patch because intermediate patch revisions are not checked in, so the message doesn't need to reference them or refer to review comments.
Attachment #8940796 - Flags: review?(paolo.mozmail) → review+

Comment 10

9 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aabf5fcec100
Removed all instances of MOZ_ENABLE_CONTENTACTION from .cpp files and moz.build file. r=paolo

Comment 11

9 months ago
I have pushed the changeset to the mozilla-inbound tree, it will be integrated with mozilla-central soon.

Thanks for your contribution!

Comment 12

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aabf5fcec100
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
status-firefox57: fix-optional → wontfix
Assignee: nobody → swapchamps
You need to log in before you can comment on or make changes to this bug.