Closed
Bug 1396667
Opened 8 years ago
Closed 8 years ago
Lots of time spent painting when selecting text on GitHub.
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
DUPLICATE
of bug 1374338
People
(Reporter: emilio, Unassigned)
References
Details
STR:
* Go to https://github.com/servo/servo/blob/c60dd53210745d9d8e7d3a5ca0310370a33553f4/components/script/dom/document.rs#L2504
* Press Ctrl + A
Expected:
* Firefox responds in a reasonable time.
Actual:
* Firefox takes much more time than Chromium painting, see https://perfht.ml/2eEfkDY
Not sure if this is something retained display lists will help fix, or if there's anything else we can do in the meantime.
Also not sure if Graphics is the right component, maybe Layout: Web Painting is a better one, please feel free to move / dupe / etc.
|
||
Comment 1•8 years ago
|
||
It looks like basically all the time is being spent in nsRange::IsNodeSelected https://perfht.ml/2vGIrO6.
Something is likely going very wrong.
Component: Graphics → Layout: Text
|
Reporter | |
Comment 2•8 years ago
|
||
Seems like we're calling that a whole lot of times to decide whether to paint the border decoration for each table cell. That function looks really expensive...
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
|
||
Comment 4•8 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> It looks like basically all the time is being spent in
> nsRange::IsNodeSelected https://perfht.ml/2vGIrO6.
...and the IsNodeSelected calls are inside of table code. See bug 1374338 comment 6 for more on how this sucks.
Whiteboard: [qf]
You need to log in
before you can comment on or make changes to this bug.
Description
•