Closed
Bug 1396714
Opened 8 years ago
Closed 8 years ago
Remove for Gecko Pref for Leanplum
Categories
(Firefox for Android Graveyard :: Metrics, enhancement, P1)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: cnevinchen, Assigned: cnevinchen)
Details
(Whiteboard: [FNC][SPT58.3][INT])
Attachments
(1 file)
GeckoPref "mma.enabled" doesn't work for Push Notification. Since we can't check its value when Gecko is not running.
There'll be no change in the document[1] because it's an extra engineering work for developers who want to disable it using the pref.
Since this pref will be marked deprecated in bug 1396548, we'll remove it after 57's merge day and let it ride 58 train.
[1] https://firefox-source-docs.mozilla.org/mobile/android/fennec/mma.html#who-will-have-leanplum-enabled
| Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904423 [details]
Bug 1396714 Remove Gecko pref 'mma.enabled'
https://reviewboard.mozilla.org/r/176232/#review181282
Attachment #8904423 -
Flags: review?(max) → review+
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904423 [details]
Bug 1396714 Remove Gecko pref 'mma.enabled'
https://reviewboard.mozilla.org/r/176232/#review181284
::: commit-message-27c06:1
(Diff revision 1)
> +Bug 1396714 Remove Gecko pref 'mma.enabled' r?maliu
Please also remove "mma.enable" section in mobile/android/app/mobile.js
| Comment hidden (mozreview-request) |
| Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
| Comment hidden (mozreview-request) |
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee282703713a
Remove Gecko pref 'mma.enabled' r=maliu
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•8 years ago
|
Whiteboard: [FNC][SPT58.3][INT]
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•