Closed Bug 1396794 Opened 7 years ago Closed 7 years ago

Dead code in FlacFrameParser::DecodeHeaderBlock

Categories

(Core :: Audio/Video: Playback, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: bharatraghunthan9767, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=C++])

Attachments

(1 file)

Priority: -- → P5
I'm new to the community and I want to make my first contribution, can someone guide me regarding this?
Sure, just submit a patch
I've removed the two dead-code increment lines for aLength and aPacket, is that all that was needed to be done?
Is this bug still available to work on()? May I submit a patch?
Flags: needinfo?(sledru)
Comment on attachment 8908621 [details]
Bug 1396794 - Removed aPacket and aLength change

Can you please review my patch in Comment #5?
Attachment #8908621 - Flags: review?(sledru)
Looks great but you should now find a reviewer (I am not the owner of this code)
Assignee: nobody → bharatraghunthan9767
Flags: needinfo?(sledru)
Can you please redirect me to the correct reviewer(s) of this code? Currently you have been listed as the mentor hence, I have flagged you for review. Could you please transfer the review flag/mentor status to the appropriate person(s)? Thanks.
Flags: needinfo?(sledru)
Flags: needinfo?(ajones)
Please see:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
and don't use need info to get review but the review in attachment


Here, mentor means that I am here to guide you, not to review patches :)
Flags: needinfo?(sledru)
Flags: needinfo?(ajones)
Attachment #8908621 - Flags: review?(sledru) → feedback+
Attachment #8908621 - Flags: review?(ajones)
Flags: needinfo?(ajones)
Comment on attachment 8908621 [details]
Bug 1396794 - Removed aPacket and aLength change

https://reviewboard.mozilla.org/r/180288/#review185842
Attachment #8908621 - Flags: review?(ajones) → review+
Thanks for the patch. For future reference, you don't need to do a needinfo? as well as a review?
Flags: needinfo?(ajones)
https://hg.mozilla.org/mozilla-central/rev/24833bf7fb61
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Is this all or is there anything more that needs to be done? Thanks <@kentuckyfriedtakahe,@sylvestre >
That is all, well done!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: