1396867 - silence -Wunused-typedef warnings in GeckoEditableSupport

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, enhancement)

Description

[Nathan Froyd [:froydnj]]

clang seems to think that `Base` is unused despite its obvious uses
inside this class.  We can deal with the `Base::` qualifications for
name lookup by using `this->` instead, and the other uses of `Base::`
can simply use the explicit name of the superclass.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: silence -Wunused-typedef warnings in GeckoEditableSupport

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8904589 [details] [diff] [review]
silence -Wunused-typedef warnings in GeckoEditableSupport

Review of attachment 8904589 [details] [diff] [review]:
-----------------------------------------------------------------

Is this worth filing a clang bug?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6eeb204f318
silence -Wunused-typedef warnings in GeckoEditableSupport; r=darchons

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b6eeb204f318