Closed Bug 1396867 Opened 2 years ago Closed 2 years ago

silence -Wunused-typedef warnings in GeckoEditableSupport

Categories

(Core :: Widget: Android, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

clang seems to think that `Base` is unused despite its obvious uses
inside this class.  We can deal with the `Base::` qualifications for
name lookup by using `this->` instead, and the other uses of `Base::`
can simply use the explicit name of the superclass.
Blocks: 1163171
Comment on attachment 8904589 [details] [diff] [review]
silence -Wunused-typedef warnings in GeckoEditableSupport

Review of attachment 8904589 [details] [diff] [review]:
-----------------------------------------------------------------

Is this worth filing a clang bug?
Attachment #8904589 - Flags: review?(nchen) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6eeb204f318
silence -Wunused-typedef warnings in GeckoEditableSupport; r=darchons
https://hg.mozilla.org/mozilla-central/rev/b6eeb204f318
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.