Add gfxPlatform::Init and gfxPlatform::GetPlatform to the prefix/skip signature list

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

3 months ago
gfxPlatform::Init is called from a bunch of different places, and I don't think we really want to bucket them all together, so it should be added to the prefix list. Of the two call sites of this method, gfxPlatform::GetPlatform is just a thin shim, and is called from many places, so I think it would make sense to add it to the skip list, because having it in the signature is not useful.

This one would turn into [@ gfxPlatform::Init | gfxPlatform::PurgeSkiaFontCache]:
bp-8fc557fa-f8f0-448c-8997-efb210170902

This one would turn into [@ gfxPlatform::Init | gfxPlatform::InitChild]:
bp-4ab3b908-ce66-4ca0-b574-171200170905

This one would turn into [@ gfxPlatform::Init | mozilla::widget::GfxInfo::GetDWriteEnabled]:
bp-8daa4147-bafe-471c-8db5-733720170905
(Assignee)

Comment 1

3 months ago
https://github.com/mozilla-services/socorro/pull/3959
Andrew: The only example of gfxPlatform::GetPlatform I could find was this one:

bp-101a31ef-393f-4be1-8db1-f61790170906

Is that a good example for that irrelevant signature change?
Flags: needinfo?(continuation)

Comment 3

3 months ago
Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/5d132e24bedd9abb2ef911ad588913bbde9a702f
Bug 1396928 - Add gfxPlatform::Init and gfxPlatform::GetPlatform to the prefix/skip signature list (#3959)

* Bug 1396928 - Add gfxPlatform::GetPlatform to irrelevant signature list

* Bug 1396928 - Add gfxPlatform::Init to prefix list
https://crash-stats.allizom.org/report/index/8fc557fa-f8f0-448c-8997-efb210170902

old: gfxPlatform::Init
new: gfxPlatform::Init | gfxPlatform::PurgeSkiaFontCache

https://crash-stats.allizom.org/report/index/4ab3b908-ce66-4ca0-b574-171200170905

old: gfxPlatform::Init
new: gfxPlatform::Init | gfxPlatform::InitChild | mozilla::dom::ContentChild::RecvSetXPCOMProcessAttributes

https://crash-stats.allizom.org/report/index/8daa4147-bafe-471c-8db5-733720170905

old: gfxPlatform::Init
new: gfxPlatform::Init | mozilla::widget::GfxInfo::GetDWriteEnabled

https://crash-stats.allizom.org/report/index/101a31ef-393f-4be1-8db1-f61790170906

old: shutdownhang | gfxPlatform::GetPlatform
new: shutdownhang | nsRefreshDriver::Tick


Andrew: Does that look right?
(Assignee)

Comment 5

3 months ago
(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #4)
> Andrew: Does that look right?

Yes, thanks!
Flags: needinfo?(continuation)
Oops--forgot to mark this FIXED.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.