1396942 - Missing buttons if build on 10.13

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P5)

Description

[Nomis101]

Attachment: Screenshot of issue

If FF/TB is build on 10.13, than the red/yellow/green buttons in the left corner are missing. This has nothing to do with the SDK, tested with 10.11, 10.12 and 10.13 SDK, all the same issue.

Comment 1

[Markus Stange [:mstange]]

If you get (In reply to Nomis101 from comment #0)
> This has nothing to do with the SDK, tested with 10.11,
> 10.12 and 10.13 SDK, all the same issue.

Can you check whether the build at https://queue.taskcluster.net/v1/task/N-CI_f3CRJ2IBMXfRBKTcg/runs/0/artifacts/public/build/target.dmg also shows this issue when run on 10.13? (I would check myself but I don't have access to 10.13 at the moment.)
That's a build from a try push from bug 1324892, but compiled on Linux. I wonder if this is really caused by building on 10.13, or if a 10.11+ SDK is enough to cause it.

Comment 2

[Nomis101]

(In reply to Markus Stange [:mstange] from comment #1)
> If you get (In reply to Nomis101 from comment #0)
> > This has nothing to do with the SDK, tested with 10.11,
> > 10.12 and 10.13 SDK, all the same issue.
> 
> Can you check whether the build at
> https://queue.taskcluster.net/v1/task/N-CI_f3CRJ2IBMXfRBKTcg/runs/0/
> artifacts/public/build/target.dmg also shows this issue when run on 10.13?
> (I would check myself but I don't have access to 10.13 at the moment.)
> That's a build from a try push from bug 1324892, but compiled on Linux. I
> wonder if this is really caused by building on 10.13, or if a 10.11+ SDK is
> enough to cause it.

This build is not showing the issue for me.
Thing is, I was able to build normally on 10.12. I have this issue since updated to 10.13 and my mozconfig did not change. In the meantime I found out, it is a combination of 10.13 and the SDK. I see the issue on all SDKs from 10.10 SDK to 10.13 SDK. But if I build with the 10.9 SDK, this fixes the issue.

Comment 3

[Stephen A Pohl [:spohl]]

Thanks! So this affects building on 10.13 only. Since our build machines aren't going to be upgraded to 10.13 anytime soon, this shouldn't block bug 1379811.

Comment 4

[Nomis101]

I confirmed that this bug is fixed on trunk. I was also able to fix it in 56 by applying locally all "10.13 patches". So, one of this patches has fixed this.