1396959 - unable to remove schedule change to required signoff

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

While making some changes to the Required Signoffs, Kim noticed that there is no way to remove a Scheduled Change to them. This is particularly problematic when there is a Scheduled Delete, because you can't simply make it no-op like you can with a Scheduled Update.

I'm not exactly sure how to put this into the current UI, but we need to find a way.

It's possible to do this through the API still, with requests such as: https://balrog-admin.stage.mozaws.net/api/scheduled_changes/required_signoffs/product/43?data_version=1&csrf_token=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Comment 1

[Alvin]

I have been looking at the bug but I cannot figure out what is required exactly. I would appreciate if you'd shed some light please.

Comment 2

[Alvin]

Attachment: Required Signoffs

I have tried to replicate the bug, according to my understanding. Is this what you are talking about on the description?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Alvin from comment #2)
> Created attachment 8909268 [details]
> Required Signoffs
> 
> I have tried to replicate the bug, according to my understanding. Is this
> what you are talking about on the description?

Not exactly. Try this:
* Go to the Permissions page and grant "balrogadmin" two Roles, "releng" and "relman"
* Go to the Required Signoffs page and create the following Required Signoffs: https://screenshots.firefoxusercontent.com/images/f4da99fb-a428-4fb1-8adf-5bb4a4298784.png
* Refresh the page once, and Signoff on the pending one to make it live. After 30 seconds and a refresh you should have: https://screenshots.firefoxusercontent.com/images/edc88339-db6a-4901-924e-9b25632519a9.png

Now that you're set-up, you can reproduce this bug by attempting to remove one of the Required Signoffs:
* Click "Edit"
* Click the "X" next to "relman", then "Save Changes".

The bug here is that once you've done that, there's no way to undo it. The edit dialog should now look like https://screenshots.firefoxusercontent.com/images/b04f0a0c-dcde-4700-8ace-c69d8f1ffacf.png, but even if you put "1" next to "relman", there's still a change scheduled.

Comment 4

[Alvin]

Attachment: bug Replication

I have tried to delete the relman role but the save changes button does nothing. If I manually change the value to zero it throws an errort to the effect that a role can only be >= 1.

Comment 5

[Alvin]

Comment on attachment 8909682 [details]
bug Replication

I have tried to delete the relman role but the save changes button does nothing. If I manually change the value to zero, I get an error that value can only be >= 1.

Comment 6

[Njira]

Thanks for the steps to reproduce Ben. So our understanding from the steps is that we cannot undo wanting to delete relman, even if we edit them to `1` from the dialog the `relman` role is still scheduled to be deleted.

We hope that is the right understanding of it.

Thanks again!

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Njira from comment #6)
> Thanks for the steps to reproduce Ben. So our understanding from the steps
> is that we cannot undo wanting to delete relman, even if we edit them to `1`
> from the dialog the `relman` role is still scheduled to be deleted.
> 
> We hope that is the right understanding of it.
> 
> Thanks again!

That's exactly right.

Comment 8

[Alvin]

Attachment: undo_delete.png

This is the way I'm planing to implement on the UI, please give me your feedback on the same.

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Alvin from comment #8)
> Created attachment 8913073 [details]
> undo_delete.png
> 
> This is the way I'm planing to implement on the UI, please give me your
> feedback on the same.

Great idea! Sorry for the delay in my response.

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/d472f3d1aa5579f03b24e06532a30f19f00fb61e
bug 1396959: Enable removal of scheduled deletes to required signoff (#420). r=bhearsum

* [bug]Enable reoval of scheduled deletes to required signoff

* [bug]Refactor code

* [bug]Refer to $key from template

* [bug]Remove unncecessary code

Comment 11

[[e-mail] (:bhearsum)]

This hit production today.