Grab Leanplum.framework from our patched version at https://github.com/st3fan/Leanplum-iOS-SDK/tree/2.0.2-DeviceName/Leanplum.framework This version includes the fix to only send the device name when the SDK is configured to run in development mode.
Created attachment 8904700 [details] [review] PR https://github.com/mozilla-mobile/firefox-ios/pull/3130 This patch points to a custom fork of https://github.com/Leanplum/Leanplum-iOS-SDK that does not send the device name at registration. The patch can be seen at https://github.com/st3fan/Leanplum-iOS-SDK/commit/7873b33d3ffe0a1a22fb90feb06ad6c604c0554d
Comment on attachment 8904700 [details] [review] PR https://github.com/mozilla-mobile/firefox-ios/pull/3130 Do we need Leanplum for all releases? Otherwise, looks good.
Attachment #8904700 - Flags: review?(jhugman) → review+
Landed on v8.x
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
I am cloning this bug to do the same thing for 9.x releases. I do however want to look into doing this in a better way. It is a bit unfortunate that we have to reference Carthage/Checkouts because Leanplum is not a proper Carthage citizen.
You need to log in before you can comment on or make changes to this bug.