1396964 - Grab Leanplum.framework from our patched version

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Grab Leanplum.framework from our patched version at https://github.com/st3fan/Leanplum-iOS-SDK/tree/2.0.2-DeviceName/Leanplum.framework

This version includes the fix to only send the device name when the SDK is configured to run in development mode.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/3130

This patch points to a custom fork of https://github.com/Leanplum/Leanplum-iOS-SDK that does not send the device name at registration.

The patch can be seen at https://github.com/st3fan/Leanplum-iOS-SDK/commit/7873b33d3ffe0a1a22fb90feb06ad6c604c0554d

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8904700 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/3130

Do we need Leanplum for all releases?

Otherwise, looks good.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on v8.x

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I am cloning this bug to do the same thing for 9.x releases.

I do however want to look into doing this in a better way. It is a bit unfortunate that we have to reference Carthage/Checkouts because Leanplum is not a proper Carthage citizen.