Closed
Bug 1396982
Opened 7 years ago
Closed 7 years ago
Make imageCacheQueue use nsTArray
Categories
(Core :: Graphics: ImageLib, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
4.48 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
While looking at bug 1396870 I noticed we are still using std::vector in the image cache code. I wrote a patch to convert it to nsTArray, use Move constructors, etc.
Assignee | ||
Comment 1•7 years ago
|
||
This patch converts imageCacheQueue to use nsTArray instead of std::vector. This is preferable for a few reasons: 1. We have runtime assertions on out-of-bounds access in nsTArray. So its safer. 2. It has a better growth algorithm instead of simple doubling. 3. It plays nicer with our memory reporters. 4. It is more consistent in handling failure conditions than different std::vector implementations. https://treeherder.mozilla.org/#/jobs?repo=try&revision=2835e2fcba400a60d45a3b8f9cb61fa7c81b3c4a
Attachment #8904730 -
Flags: review?(tnikkel)
Updated•7 years ago
|
Attachment #8904730 -
Flags: review?(tnikkel) → review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb36a2188f6f Make imageCacheQueue use nsTArray instead of std::vector. r=tnikkel
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb36a2188f6f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•