Closed Bug 1397168 Opened 4 years ago Closed 4 years ago

stylo: Add a function to find out if a node has any ancestor that is pending for restyling

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

52 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: wcpan, Assigned: wcpan)

References

Details

Attachments

(1 file)

bug 1363805 needs a function to know if any ancestor of an element is pending for restyling in Servo.

Note we don't want to check dirty descendants from parent because that flag can also be set for irrelevant subtree.
Comment on attachment 8904900 [details]
Bug 1397168 - Add a function to find out if a node has any ancestor that is pending for restyling.

https://reviewboard.mozilla.org/r/176688/#review181686

::: layout/base/ServoRestyleManager.h:191
(Diff revision 1)
>                             nsRestyleHint aRestyleHint);
>    void PostRebuildAllStyleDataEvent(nsChangeHint aExtraHint,
>                                      nsRestyleHint aRestyleHint);
>    void ProcessPendingRestyles();
>    void ProcessAllPendingAttributeAndStateInvalidations();
> +  bool HasPendingRestyleAncestor(nsINode* aNode) const;

This looks ok, but as I said I think this should just take `Element`s.

With that, r=me.
Attachment #8904900 - Flags: review?(emilio) → review+
Priority: -- → P4
Assignee: nobody → wpan
Pushed by wpan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d12b61881a56
Add a function to find out if a node has any ancestor that is pending for restyling. r=emilio
https://hg.mozilla.org/mozilla-central/rev/d12b61881a56
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.