1397231 - Crash in mozalloc_abort | NS_DebugBreak | mozilla::ipc::FatalError | mozilla::dom::PContentChild::SendPURLClassifierLocalConstructor

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-bfcbdb86-c503-4d1e-9c5f-912ce0170905.
=============================================================

There are 3 crashes in nightly 57 with buildid 20170905100117. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1345058.

[1] https://hg.mozilla.org/mozilla-central/rev?node=e29cf8ae2c4641886cf75eb7509edf59c511ceb1

Comment 1

[Ethan Tseng [:ethan]]

Thomas, this bug is critical and urgent.
Could you look into it ASAP?

Comment 2

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1397231 - Skip new URLClassifierLocalChild when ContentChild is shutting down

Review commit: https://reviewboard.mozilla.org/r/177212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177212/

Comment 3

[Thomas Nguyen (:tnguyen)]

It looks like the problem happens in shutdown. I see we check ContentChild::IsShuttingDown before doing a send in many places, it's appropriate to do something the same here.

Comment 4

[(no longer active)]

Another one of these IPC crashes during shutdown...

Comment 5

[(no longer active)]

Comment on attachment 8905407 [details]
Bug 1397231 - Skip new URLClassifierLocalChild when ContentChild is shutting down

https://reviewboard.mozilla.org/r/177212/#review182376

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f41d54eddd16
Skip new URLClassifierLocalChild when ContentChild is shutting down r=Ehsan

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f41d54eddd16