Closed Bug 1397231 Opened 2 years ago Closed 2 years ago

Crash in mozalloc_abort | NS_DebugBreak | mozilla::ipc::FatalError | mozilla::dom::PContentChild::SendPURLClassifierLocalConstructor

Categories

(Toolkit :: Safe Browsing, defect, P1, critical)

57 Branch
Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: calixte, Assigned: tnguyen)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [clouseau])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-bfcbdb86-c503-4d1e-9c5f-912ce0170905.
=============================================================

There are 3 crashes in nightly 57 with buildid 20170905100117. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1345058.

[1] https://hg.mozilla.org/mozilla-central/rev?node=e29cf8ae2c4641886cf75eb7509edf59c511ceb1
Flags: needinfo?(tnguyen)
Priority: -- → P1
Thomas, this bug is critical and urgent.
Could you look into it ASAP?
Assignee: nobody → tnguyen
Flags: needinfo?(tnguyen)
Crash Signature: [@ mozalloc_abort | NS_DebugBreak | mozilla::ipc::FatalError | mozilla::dom::PContentChild::SendPURLClassifierLocalConstructor] → [@ mozalloc_abort | NS_DebugBreak | mozilla::ipc::FatalError | mozilla::dom::PContentChild::SendPURLClassifierLocalConstructor] [@ mozalloc_abort | NS_DebugBreak | mozilla::ipc::FatalError | mozilla::ipc::IProtocol::HandleFatalError | mozilla::ipc::IProt…
It looks like the problem happens in shutdown. I see we check ContentChild::IsShuttingDown before doing a send in many places, it's appropriate to do something the same here.
Status: NEW → ASSIGNED
Another one of these IPC crashes during shutdown...
Comment on attachment 8905407 [details]
Bug 1397231 - Skip new URLClassifierLocalChild when ContentChild is shutting down

https://reviewboard.mozilla.org/r/177212/#review182376
Attachment #8905407 - Flags: review?(ehsan) → review+
Pushed by tnguyen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f41d54eddd16
Skip new URLClassifierLocalChild when ContentChild is shutting down r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/f41d54eddd16
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.