Closed
Bug 1397371
Opened 7 years ago
Closed 7 years ago
Remove the assertion and telemetry for ensuring that documents and friends can never end up with an expanded principal
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
In bug 1301123 we added an assertion and telemetry for this, but so far we haven't seen any violations <https://mzl.la/2xPjwFK> and the telemetry probe is about to expire now. It's probably safe to remove this now.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8905158 -
Flags: review?(bobbyholley)
Comment 2•7 years ago
|
||
Comment on attachment 8905158 [details] [diff] [review] Remove the assertion and telemetry for ensuring that documents and friends can never end up with an expanded principal Review of attachment 8905158 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsNodeInfoManager.cpp @@ -418,5 @@ > } > > NS_ASSERTION(aPrincipal, "Must have principal by this point!"); > - MOZ_DIAGNOSTIC_ASSERT(!nsContentUtils::IsExpandedPrincipal(aPrincipal), > - "Documents shouldn't have an expanded principal"); Should we consider keeping the assertion? It doesn't cost us much, and is probably good checking in case somebody screws this up.
Attachment #8905158 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #2) > Comment on attachment 8905158 [details] [diff] [review] > Remove the assertion and telemetry for ensuring that documents and friends > can never end up with an expanded principal > > Review of attachment 8905158 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/base/nsNodeInfoManager.cpp > @@ -418,5 @@ > > } > > > > NS_ASSERTION(aPrincipal, "Must have principal by this point!"); > > - MOZ_DIAGNOSTIC_ASSERT(!nsContentUtils::IsExpandedPrincipal(aPrincipal), > > - "Documents shouldn't have an expanded principal"); > > Should we consider keeping the assertion? It doesn't cost us much, and is > probably good checking in case somebody screws this up. Sure, why not.
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d492424cba2 Remove the telemetry for ensuring that documents and friends can never end up with an expanded principal; r=bholley
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d492424cba2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•