1397371 - Remove the assertion and telemetry for ensuring that documents and friends can never end up with an expanded principal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[(no longer active)]

In bug 1301123 we added an assertion and telemetry for this, but so far we haven't seen any violations <https://mzl.la/2xPjwFK> and the telemetry probe is about to expire now.  It's probably safe to remove this now.

Comment 1

[(no longer active)]

Attachment: Remove the assertion and telemetry for ensuring that documents and friends can never end up with an expanded principal

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8905158 [details] [diff] [review]
Remove the assertion and telemetry for ensuring that documents and friends can never end up with an expanded principal

Review of attachment 8905158 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsNodeInfoManager.cpp
@@ -418,5 @@
>    }
>  
>    NS_ASSERTION(aPrincipal, "Must have principal by this point!");
> -  MOZ_DIAGNOSTIC_ASSERT(!nsContentUtils::IsExpandedPrincipal(aPrincipal),
> -                        "Documents shouldn't have an expanded principal");

Should we consider keeping the assertion? It doesn't cost us much, and is probably good checking in case somebody screws this up.

Comment 3

[(no longer active)]

(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #2)
> Comment on attachment 8905158 [details] [diff] [review]
> Remove the assertion and telemetry for ensuring that documents and friends
> can never end up with an expanded principal
> 
> Review of attachment 8905158 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/base/nsNodeInfoManager.cpp
> @@ -418,5 @@
> >    }
> >  
> >    NS_ASSERTION(aPrincipal, "Must have principal by this point!");
> > -  MOZ_DIAGNOSTIC_ASSERT(!nsContentUtils::IsExpandedPrincipal(aPrincipal),
> > -                        "Documents shouldn't have an expanded principal");
> 
> Should we consider keeping the assertion? It doesn't cost us much, and is
> probably good checking in case somebody screws this up.

Sure, why not.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d492424cba2
Remove the telemetry for ensuring that documents and friends can never end up with an expanded principal; r=bholley

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4d492424cba2