1397372 - Open bookmarks in the current tab when middleclicked if browser.tabs.loadBookmarksInTabs is set to true

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect, P5)

Description

[Serge]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170824053622

Steps to reproduce:

Resolution of https://bugzilla.mozilla.org/show_bug.cgi?id=658245 introduced ability to open bookmarks in new tab (with left mouse-click) instead of current one by default.

Enable new feature by setting browser.tabs.loadBookmarksInTabs:true in about:config


Actual results:

Left mouse-click opens bookmarks in new tab
Middle mouse-click opens bookmarks in new tab


Expected results:

Left mouse-click opens bookmarks in new tab
Middle mouse-click opens bookmarks in current tab


Why it sound like a bug?
Before browser.tabs.loadBookmarksInTabs was introduced there was a possibility to open bookmark in new or current tab (with different effort from user).
After entablement of browser.tabs.loadBookmarksInTabs:true there is no convenient way to open bookmark in current tab.

The whole feature is very useful and much needed however it sounds more logical if it acted as toggler to switch functionality of left mouse-click and middle mouse-click when used with bookmarks.

Comment 1

[:Gijs (he/him)]

Not a security bug that needs to stay hidden...

Comment 2

[Justin Dolske [:Dolske]]

Just to confirm -- I assume middle-click opens the bookmark in a new tab (before this pref was introduced, and when it's set to false). And so the issue is that when setting the pref to true, it effectively breaks using middle-click to open bookmarks in a new tab?

(I would agree that middle-click should always open in a new tab.)

Comment 3

[YF (Yang)]

Perhaps should adding an pref to meet this needs, like browser.tabs.inversionClickforLoadBookmarks or browser.tabs.loadBookmarksInTabs.inversionClick.

Comment 4

[:Gijs (he/him)]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Just to confirm -- I assume middle-click opens the bookmark in a new tab
> (before this pref was introduced, and when it's set to false). And so the
> issue is that when setting the pref to true, it effectively breaks using
> middle-click to open bookmarks in a new tab?

(In reply to Serge from comment #0)
> Expected results:
> 
> Middle mouse-click opens bookmarks in current tab

So I think comment #0 is requesting that with the pref flipped, middle click should open in the *current* tab, rather than a new tab.

> After [enabling] browser.tabs.loadBookmarksInTabs:true there is no
> convenient way to open bookmark in current tab.

There is, you can right click the bookmark and click 'open'.

> The whole feature is very useful and much needed however it sounds more
> logical if it acted as toggler to switch functionality of left mouse-click
> and middle mouse-click when used with bookmarks.

I think comment #2 disagrees, and I do too. I think we should close this as wontfix.

Comment 5

[:Gijs (he/him)]

Clarifying what I'm wontfixing.

Comment 7

[Yuri Khan]

I started a thread on the firefox-dev mailing list regarding this bug and bug 1416545.

:Dolske, :Gijs, would you care to join the discussion with your reasons against applying the changes proposed either here or in 1416545?

Comment 8

[Yuri Khan]

https://mail.mozilla.org/pipermail/firefox-dev/2017-December/005995.html