1397513 - Replace uses of ExposedPropertiesOnly policy with Opaque

Status: NEW

(Core :: XPConnect, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

Once bug 1377587 is fixed, ExposedPropertiesOnly will be the same as Opaque, except that it fails silently for GET, ENUMERATE, and GET_PROPERTY_DESCRIPTOR. Failing noisily causes various things to break, but once that is fixed then we can just use Opaque. This will also allow the removal of WrapperDenialForCOW.

Comment 1

[Andrew McCreight [:mccr8]]

The holdup here is that I'm getting weird test failures. I figured that since the failures in bug 1377587 would be easy to fix, the failures for this would also be easy to fix, but unfortunately that hasn't been the case. My theory is that CPOWs are to blame, but the failures are happening inside some complicated Task.jsm stuff so I'm not sure where it is going wrong.

Comment 2

[Kris Maglione [:kmag]]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> My theory is that CPOWs are to blame, but the failures are happening inside
> some complicated Task.jsm stuff so I'm not sure where it is going wrong.

Hm. All of the failures? I thought we'd gotten rid of the last in-tree uses of
Task.jsm already...

Comment 3

[Andrew McCreight [:mccr8]]

Well, maybe that was just the first one I looked at, then gave up in despair. This was for
  browser_storage_dynamic_updates_localStorage.js
I may be mixing up the name of the library.

Comment 4

[Andrew McCreight [:mccr8]]

(The simplest way to try this out locally is to delete the body of OpaqueWithSilentFailing::deny() so it just does return false and nothing else.)