Closed
Bug 1397577
Opened 8 years ago
Closed 8 years ago
Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement()
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
3.11 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8905337 -
Flags: review?(bugs)
|
||
Updated•8 years ago
|
Assignee: nobody → ehsan
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8905337 [details] [diff] [review]
Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement()
You don't ever call GetChildAtFocusOffset. I assume you're planning to add callers. If not, remove.
Attachment #8905337 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
I don't have any immediate callers right now, but I suspected there will be some. I guess I can remove for now and add it back later.
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98982ca12062
Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement(); r=smaug
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•