Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement()

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Created attachment 8905337 [details] [diff] [review]
Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement()
Attachment #8905337 - Flags: review?(bugs)
(Assignee)

Updated

a year ago
Blocks: 651120
Assignee: nobody → ehsan
Comment on attachment 8905337 [details] [diff] [review]
Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement()

You don't ever call GetChildAtFocusOffset. I assume you're planning to add callers. If not, remove.
Attachment #8905337 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

a year ago
I don't have any immediate callers right now, but I suspected there will be some.  I guess I can remove for now and add it back later.

Comment 4

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98982ca12062
Avoid using GetChildAt() in HTMLEditor::GetSelectedOrParentTableElement(); r=smaug
https://hg.mozilla.org/mozilla-central/rev/98982ca12062
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.