Closed Bug 1397651 Opened 7 years ago Closed 7 years ago

Update tests within devtools/ to comply with new toplevel data: URI navigation policy

Categories

(Core :: DOM: Security, enhancement, P1)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

bug_1397651_devtools_tests.patch
4.73 KB, patch
bgrins
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 1380959
Priority: -- → P3
Whiteboard: [domsecurity-backlog1]
Brian, we are about to block toplevel data: URI navigations within Firefox (because those navigations are mostly only used for phishing attempts). Flipping the pref |security.data_uri.block_toplevel_data_uri_navigations| causes two tests within devtools/ to fail:
* browser_markup_update-on-navigtion.js
* test_saveHeapSnapshot_e10s_01.html

Please note that even though the updated code within test_saveHeapSnapshot_e10s_01.html looks like it's an iframe, it's created through mozbrowser, which basically creates a new toplevel context, hence it would be blocked by the pref.
Attachment #8905413 - Flags: review?(bgrinstead)
Priority: P3 → P1
Whiteboard: [domsecurity-backlog1] → [domsecurity-active]
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Attachment #8905413 - Flags: review?(bgrinstead) → review+
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/860d5124faec
Update tests within devtools/ to comply with new toplevel data: URI navigation policy. r=bgrinstead
https://hg.mozilla.org/mozilla-central/rev/860d5124faec
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: