1397711 - Crash when invoking nsDOMWindowUtils::DispatchDOMEventViaPresShell with a script-created keypress event

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

This causes some issue with old extensions, see https://github.com/willsALMANJ/pentadactyl-signed/issues/4

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1397711 - Null-check widget of keyboard event before invoking its PostHandleKeyEvent.

Review commit: https://reviewboard.mozilla.org/r/177282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177282/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Note that the same null-check presents in the original callsite of PostHandleKeyEvent: https://searchfox.org/mozilla-central/rev/67f38de2443e6b613d874fcf4d2cd1f2fc3d5e97/dom/ipc/TabParent.cpp#2228-2231

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8905472 [details]
Bug 1397711 - Null-check widget of keyboard event before invoking its PostHandleKeyEvent.

https://reviewboard.mozilla.org/r/177282/#review182332

Nice.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/385a77f98b68
Null-check widget of keyboard event before invoking its PostHandleKeyEvent. r=masayuki

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/385a77f98b68

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8905472 [details]
Bug 1397711 - Null-check widget of keyboard event before invoking its PostHandleKeyEvent.

Approval Request Comment
[Feature/Bug causing the regression]: bug 429824
[User impact if declined]: Reliably crash with some extensions, see willsALMANJ/pentadactyl-signed#4
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: just landed
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just add a null-check
[String changes made/needed]: n/a

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8905472 [details]
Bug 1397711 - Null-check widget of keyboard event before invoking its PostHandleKeyEvent.

Add a null check. Should be low risk. Beta56+.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e0ce4bfc27ef

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8905472 [details]
Bug 1397711 - Null-check widget of keyboard event before invoking its PostHandleKeyEvent.

m-r is about to become 56, so this is wontfix for 55.