1397721 - [cross-channel] Build beta from l10n-central

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Axel Hecht [:Pike]]

When we do cross-channel l10n, we'll use the l10n-central repositories to localize the affected channels.

The actual cross-channel setup will ride the trains, so if we're making 57, we'll want all of 57 to build from l10n-central.

This doesn't affect sign-offs, they'll still be needed and wanted, and we'll provide the data at the usual URLs.

I know that we'll need to edit the in-tree data, which is easy.

But I also found a couple of references in https://dxr.mozilla.org/build-central/search?q=releases%2Fl10n%2Fmozilla-beta&redirect=false

If we're making 57 depends on us having the underlying infrastructure, like the generated en-US repository, and an OK way to update it. Those items are tracked in bug 1397720.

If we make 57, we'll want this to be in-tree (and wherelse needed) by the merge on the 14th.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1397721, build from l10n-central instead of releases/l10n/mozilla-beta for cross-channel l10n,

Review commit: https://reviewboard.mozilla.org/r/177290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177290/

Comment 2

[Axel Hecht [:Pike]]

Attachment: bug 1397721, build from l10n-central instead of releases/l10n/mozilla-release for cross-channel l10n,

This change rides the train along with the change to build beta from
l10n-central.
Not changing 52 esr config, as that continues to build from the
repository it's currently building from.
ESR will be picked up when the next ESR is riding the trains from central.

Review commit: https://reviewboard.mozilla.org/r/177292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177292/

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8905477 [details]
bug 1397721, build from l10n-central instead of releases/l10n/mozilla-beta for cross-channel l10n,

https://reviewboard.mozilla.org/r/177290/#review183940

missing the android *.json entries in https://dxr.mozilla.org/mozilla-central/search?q=l10n%2Fmozilla-beta

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8905478 [details]
bug 1397721, build from l10n-central instead of releases/l10n/mozilla-release for cross-channel l10n,

https://reviewboard.mozilla.org/r/177292/#review183942

r- for the same reason as the first patch, though I would put a cautionary comment in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/single_locale/mozilla-esr52.py to alert whoever is prepping the next ESR cycle that we should use l10n central for cross channel (or maybe to consult l10n team on if we want cross-channel l10n for the next esr).

Comment 5

[Justin Wood (:Callek)]

Attachment: Patch to flip the basic config entry for Buildbot r=kmoir

This patch can land now, and flips the config entry for BB

Comment 6

[Justin Wood (:Callek)]

Attachment: Beta Patch for 57 Merge day

This patch must land on merge day before the first 57 beta

Comment 7

[Justin Wood (:Callek)]

Attachment: Patch for merge day for 57's merge to release. Must merge before 57.0 GTB

This patch must land once we're ready to GTB for 57.0

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 8905477 [details]
bug 1397721, build from l10n-central instead of releases/l10n/mozilla-beta for cross-channel l10n,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177290/diff/1-2/

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 8905478 [details]
bug 1397721, build from l10n-central instead of releases/l10n/mozilla-release for cross-channel l10n,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177292/diff/1-2/

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 8905477 [details]
bug 1397721, build from l10n-central instead of releases/l10n/mozilla-beta for cross-channel l10n,

https://reviewboard.mozilla.org/r/177290/#review184408

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 8905478 [details]
bug 1397721, build from l10n-central instead of releases/l10n/mozilla-release for cross-channel l10n,

https://reviewboard.mozilla.org/r/177292/#review184412

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fef4a3d0683
build from l10n-central instead of releases/l10n/mozilla-beta for cross-channel l10n, r=Callek
https://hg.mozilla.org/integration/autoland/rev/659c80698229
build from l10n-central instead of releases/l10n/mozilla-release for cross-channel l10n, r=Callek

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1fef4a3d0683
https://hg.mozilla.org/mozilla-central/rev/659c80698229

Comment 14

[Justin Wood (:Callek)]

Comment on attachment 8907272 [details] [diff] [review]
Beta Patch for 57 Merge day

Review of attachment 8907272 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to split this patch, turns out we'll be doing a beta 56 of fennec *after* we kick a beta 57 of devedition, so we need this to land seperately.

Comment 15

[Justin Wood (:Callek)]

Attachment: Update TB release config files for 57 beta

Kim already reviewed this change, so r+ and just splitting the patch.

Comment 16

[Justin Wood (:Callek)]

Attachment: Update Fennec release configs for beta

Kim already reviewed

Comment 17

[Justin Wood (:Callek)]

Summary:

* I'm landing https://bugzilla.mozilla.org/attachment.cgi?id=8907271 now
* https://bugzilla.mozilla.org/attachment.cgi?id=8907886 is needed by the first TB beta based on 57.
* https://bugzilla.mozilla.org/attachment.cgi?id=8907887 can only land after the last 56 beta, and before the first fennec 57 beta.
* for next merge day (57 to release) need to land https://bugzilla.mozilla.org/attachment.cgi?id=8907274

After I land that first one, I'll add the details into releasewarrior.

Comment 18

[Justin Wood (:Callek)]

Comment on attachment 8907271 [details] [diff] [review]
Patch to flip the basic config entry for Buildbot r=kmoir

Review of attachment 8907271 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbot-configs/rev/618145e94126563ef918b2387c43f7afd69bca99

Comment 19

[Justin Wood (:Callek)]

Johan, FYI there are patches here that need to be reconfig'd before GTB's come in, see https://github.com/mozilla/releasewarrior/commit/fc94fa73720955c15a5b40bc92d5a31dd78ffbf7

Comment 20

[Johan Lorenzo [:jlorenzo]]

Thanks for the heads up. Callek and I discussed this on IRC. We don't think Fennec 56.0b13 will be impacted by the reconfigs, because changesets are defined in-tree. There might be some wrong behavior on the mozharness side. I'll keep an eye on it, next week.

:Pike just confirmed over email that l10n-central was indeed used in release-promotion. This is the case in [1], for instance.

[1] https://archive.mozilla.org/pub/devedition/tinderbox-builds/mozilla-beta-l10n/release-mozilla-beta_devedition_linux_l10n_repack-bm74-build1-build134.txt.gz

Comment 21

[Kim Moir [:kmoir] ET]

Callek, can this be closed?  Lizzard was pinging me about the state of the bug it blocks and this bug is still listed as open.

Comment 22

[Justin Wood (:Callek)]

Indeed it can

Comment 23

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.