Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: mccr8, Assigned: droeh)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 58
All
Android
Points:
---

Firefox Tracking Flags

(fennec+, firefox55 wontfix, firefox56 wontfix, firefox57blocking fixed, firefox58 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 months ago
(In reply to Richard Newman [:rnewman] from comment #3)
> Please file an additional bug to delete any existing logs, and have it block
> Bug 1042369. Hooray for less storage impact!

As seen in bug 1393058, some users get the storage on their phones filled up with GC/CC logs, which are intended only for debugging. rnewman asked for a bug on deleting existing logs, so here it is.
(Reporter)

Updated

2 months ago
Component: Core → General
Product: Android Background Services → Firefox for Android
Blocks: 1042369
OS: Unspecified → Android
Hardware: Unspecified → All
[Tracking Requested - why for this release]: This is hundreds or thousands of megabytes for affected users. This is not something we should delay in fixing.
tracking-fennec: --- → ?
status-firefox55: --- → wontfix
status-firefox56: --- → affected
status-firefox57: --- → affected
tracking-firefox57: --- → ?
Assignee: nobody → droeh
tracking-fennec: ? → +
Priority: -- → P1
status-firefox56: affected → wontfix
status-firefox58: --- → affected

Comment 2

2 months ago
I'd like to track this as a blocking bug for Fennec 57. The sooner this is fixed the better.
tracking-firefox57: ? → blocking
Dylan, could you share a status update on this bug?  Thanks.
(Assignee)

Comment 4

a month ago
Created attachment 8919491 [details] [diff] [review]
Delete Downloads/memory-reports on startup if it exists

An easy enough fix once I was able to actually test it! This just uses DelayedInit to spawn a task to delete the log directory if it exists.
Attachment #8919491 - Flags: review?(snorp)
(Assignee)

Comment 5

a month ago
Created attachment 8919492 [details] [diff] [review]
Delete Downloads/memory-reports on startup if it exists

Forgot to include a commit message! Otherwise same as above.
Attachment #8919491 - Attachment is obsolete: true
Attachment #8919491 - Flags: review?(snorp)
Attachment #8919492 - Flags: review?(snorp)
Attachment #8919491 - Flags: review+
Attachment #8919492 - Flags: review?(snorp) → review+

Comment 6

a month ago
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bde8a772d008
Delete Downloads/memory-reports if it exists. r=snorp

Comment 7

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bde8a772d008
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
57 blocker. Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(droeh)
(Assignee)

Comment 9

a month ago
Comment on attachment 8919492 [details] [diff] [review]
Delete Downloads/memory-reports on startup if it exists

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Potentially wasting large amounts of storage on affected devices.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Minimally so
[Why is the change risky/not risky?]: Deletes a directory that should only exist if we've used it for logging purposes
[String changes made/needed]: None
Flags: needinfo?(droeh)
Attachment #8919492 - Flags: approval-mozilla-beta?
Comment on attachment 8919492 [details] [diff] [review]
Delete Downloads/memory-reports on startup if it exists

blocking issue, taking it.
Attachment #8919492 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 11

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b2699930e944
status-firefox57: affected → fixed
You need to log in before you can comment on or make changes to this bug.