Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: droeh)

Tracking

(Blocks 1 bug)

unspecified
Firefox 58
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(fennec+, firefox55 wontfix, firefox56 wontfix, firefox57blocking fixed, firefox58 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(In reply to Richard Newman [:rnewman] from comment #3)
> Please file an additional bug to delete any existing logs, and have it block
> Bug 1042369. Hooray for less storage impact!

As seen in bug 1393058, some users get the storage on their phones filled up with GC/CC logs, which are intended only for debugging. rnewman asked for a bug on deleting existing logs, so here it is.
Component: Core → General
Product: Android Background Services → Firefox for Android
Blocks: 1042369
OS: Unspecified → Android
Hardware: Unspecified → All
[Tracking Requested - why for this release]: This is hundreds or thousands of megabytes for affected users. This is not something we should delay in fixing.
tracking-fennec: --- → ?
Assignee: nobody → droeh
tracking-fennec: ? → +
Priority: -- → P1
I'd like to track this as a blocking bug for Fennec 57. The sooner this is fixed the better.
Dylan, could you share a status update on this bug?  Thanks.
An easy enough fix once I was able to actually test it! This just uses DelayedInit to spawn a task to delete the log directory if it exists.
Attachment #8919491 - Flags: review?(snorp)
Forgot to include a commit message! Otherwise same as above.
Attachment #8919491 - Attachment is obsolete: true
Attachment #8919491 - Flags: review?(snorp)
Attachment #8919492 - Flags: review?(snorp)
Attachment #8919492 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bde8a772d008
Delete Downloads/memory-reports if it exists. r=snorp
https://hg.mozilla.org/mozilla-central/rev/bde8a772d008
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
57 blocker. Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(droeh)
Comment on attachment 8919492 [details] [diff] [review]
Delete Downloads/memory-reports on startup if it exists

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Potentially wasting large amounts of storage on affected devices.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Minimally so
[Why is the change risky/not risky?]: Deletes a directory that should only exist if we've used it for logging purposes
[String changes made/needed]: None
Flags: needinfo?(droeh)
Attachment #8919492 - Flags: approval-mozilla-beta?
Comment on attachment 8919492 [details] [diff] [review]
Delete Downloads/memory-reports on startup if it exists

blocking issue, taking it.
Attachment #8919492 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.