1397928 - Remove some unused type declarations from IPC process_util

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I ran across some type declarations in process_util{.h,_linux.cc} that are no longer used; we might as well delete them.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1397928 - Remove some unused type definitions from process_util.

Review commit: https://reviewboard.mozilla.org/r/177492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177492/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8905695 [details]
Bug 1397928 - Remove some unused type definitions from process_util.

https://reviewboard.mozilla.org/r/177492/#review186714

::: ipc/chromium/src/base/process_util.h:44
(Diff revision 1)
>  typedef PROCESSENTRY32 ProcessEntry;
>  typedef IO_COUNTERS IoCounters;

Could we get rid of these too? Seems like they're also unused.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Bill McCloskey (:billm) from comment #2)
> Could we get rid of these too? Seems like they're also unused.

Nice catch.  They do seem to be unused, but I'll re-Try to make sure.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8905695 [details]
Bug 1397928 - Remove some unused type definitions from process_util.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177492/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c883feee819
Remove some unused type definitions from process_util. r=billm

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c883feee819