Closed Bug 1397930 Opened 2 years ago Closed 2 years ago

Official builds of Fennec need to use the same Safe Browsing client ID as desktop

Categories

(Toolkit :: Safe Browsing, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

(Whiteboard: #sbv4-m10)

Attachments

(1 file)

On Desktop, official builds use navclient-auto-ffox as a Safe Browsing client ID:

https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/modules/libpref/init/all.js#5415-5421

On Fennec, however, it's set to "Firefox":

https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/mobile/android/app/mobile.js#647
https://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/mobile/android/confvars.sh#10

We should make all official builds use the "official" client ID of "navclient-auto-ffox" and maybe non-official builds should use @MOZ_APP_UA_NAME@ if it's also set on desktop.
(In reply to François Marier [:francois] from comment #0)
> maybe non-official builds should use
> @MOZ_APP_UA_NAME@ if it's also set on desktop.

Can't use that variable on Desktop, it doesn't appear to be defined. However, we can use %NAME% which is normally defined as "Firefox".

The advantage of doing this is that we'll be able to tell things rebrands of Firefox apart in server-side error logs.
Summary: Official builds of Fennec needs to use the same Safe Browsing client ID as desktop → Official builds of Fennec need to use the same Safe Browsing client ID as desktop
Comment on attachment 8905734 [details]
Bug 1397930 - Use the same Safe Browsing client ID on all official builds.

https://reviewboard.mozilla.org/r/177538/#review184338

Maybe mention it to the Google guys if you still talk to them regularly. Doubt they'll notice much, though.
Attachment #8905734 - Flags: review?(gpascutto) → review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/956163f1fa0e
Use the same Safe Browsing client ID on all official builds. r=gcp
(In reply to Gian-Carlo Pascutto [:gcp] from comment #3)
> Maybe mention it to the Google guys if you still talk to them regularly.

Will do, thanks.
Can you please review this simpler patch?

Google asked us to treat all forks the same ("Firefox").
Flags: needinfo?(gpascutto)
Comment on attachment 8905734 [details]
Bug 1397930 - Use the same Safe Browsing client ID on all official builds.

https://reviewboard.mozilla.org/r/177538/#review184678
LGTM.
Flags: needinfo?(gpascutto)
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfd5924a10e3
Use the same Safe Browsing client ID on all official builds. r=gcp
https://hg.mozilla.org/mozilla-central/rev/cfd5924a10e3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.