Closed Bug 1397937 Opened 2 years ago Closed 2 years ago

Stylo: Prune unused FFI structs that trigger Linux 32-bit alignment issues

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

JS::Value and things that include it transitively can't be represented correctly by bindgen for Linux 32-bit yet.

Also, they aren't used by Stylo anyway, so let's just prune the types out.
:froydnj, is this sufficient to get your layout test runs passing for Linux 32-bit?
Flags: needinfo?(nfroyd)
Comment on attachment 8905704 [details]
Bug 1397937 - Prune unused FFI types with Linux 32-bit issues.

https://reviewboard.mozilla.org/r/177500/#review182648
Attachment #8905704 - Flags: review?(emilio) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ed8bd83b7ec6
Prune unused FFI types with Linux 32-bit issues. r=emilio
https://hg.mozilla.org/mozilla-central/rev/ed8bd83b7ec6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> :froydnj, is this sufficient to get your layout test runs passing for Linux
> 32-bit?

It's sufficient to remove the failures, thanks!
Flags: needinfo?(nfroyd)
You need to log in before you can comment on or make changes to this bug.