If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Stylo: Prune unused FFI structs that trigger Linux 32-bit alignment issues

RESOLVED FIXED in Firefox 57

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
18 days ago
13 days ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

JS::Value and things that include it transitively can't be represented correctly by bindgen for Linux 32-bit yet.

Also, they aren't used by Stylo anyway, so let's just prune the types out.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

18 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd7a7bfe6f680e105173b102452ce0c983a9e5a9
(Assignee)

Comment 3

18 days ago
:froydnj, is this sufficient to get your layout test runs passing for Linux 32-bit?
Flags: needinfo?(nfroyd)

Comment 4

18 days ago
mozreview-review
Comment on attachment 8905704 [details]
Bug 1397937 - Prune unused FFI types with Linux 32-bit issues.

https://reviewboard.mozilla.org/r/177500/#review182648
Attachment #8905704 - Flags: review?(emilio) → review+

Comment 5

18 days ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ed8bd83b7ec6
Prune unused FFI types with Linux 32-bit issues. r=emilio

Comment 6

18 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ed8bd83b7ec6
Status: ASSIGNED → RESOLVED
Last Resolved: 18 days ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> :froydnj, is this sufficient to get your layout test runs passing for Linux
> 32-bit?

It's sufficient to remove the failures, thanks!
Flags: needinfo?(nfroyd)
You need to log in before you can comment on or make changes to this bug.