1397949 - DOMMatrix.prototype.translate doesn't work with one argument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[bjornson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170904100131

Steps to reproduce:

> var x = new DOMMatrix()
> x.translate(1)
TypeError: Not enough arguments to DOMMatrixReadOnly.translate.

All arguments are optional; y and z should default to 0.

Comment 1

[bjornson]

The operation is also incorrect for some overloads. For example:

> x.translate(2,3,4,5).toFloat64Array().join(",")
"1,0,0,0,0,1,0,0,0,0,1,0,2,3,4,1" // wrong
"2,0,0,0,0,3,0,0,0,0,4,0,-5,0,0,1" // <-- correct

---

Most of the DOMMatrix.prototype methods I'm testing have similar issues (e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1397945). Is it helpful if I continue open separate issues, or should Firefox's implementation just be reviewed as a whole?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Looks like the spec has changed at some point.

Comment 3

[(no longer active)]

Yes, the spec here has changed: https://drafts.fxtf.org/geometry/#DOMMatrix

Chromium implements the new spec since https://codereview.chromium.org/2387003002.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1397949: Mark all arguments as optional on DOMMatrix translate*()/skew*()

The spec allows zero argument calls, so this change implements it. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94b2eb5869ae41e431c9e277abb62b5a19a69579

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c589c8bb562
Mark all arguments as optional on DOMMatrix translate*()/skew*() r=bzbarsky

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5c589c8bb562

Comment 7

[Eric Shepherd [:sheppy]]

Documentation updated:

• Updated the DOMMatrix and DOMMatrixReadOnly pages accordingly.
• Submitted BCD PR 4823 to update the compatibility data for the affected methods.

Please advise if there are any remaining issues with the content affected here.