1397955 - `get_pings_properties` returns `None` for boolean scalars which are false

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect)

Description

[Matthew N. [:MattN]]

Attachment: Subset of affected code

`get_pings_properties(pings, ["payload/processes/parent/scalars/formautofill.availability"])` should return a boolean scalar but it only return True or None (never False).

I think this may be a regression from 1318326, specifically https://github.com/mozilla/python_moztelemetry/commit/df5b7d2ee525088b098adb7281f7f14230290835#diff-8b027ef9288ec2f60a0eb3833d282e0cL171

Comment 1

[Matthew N. [:MattN]]

Oops, I had the wrong line: https://github.com/mozilla/python_moztelemetry/commit/df5b7d2ee525088b098adb7281f7f14230290835#diff-8b027ef9288ec2f60a0eb3833d282e0cL245

Comment 2

[Matthew N. [:MattN]]

Attachment: Link to Github pull-request: https://github.com/mozilla/python_moztelemetry/pull/175

Comment 3

[Matthew N. [:MattN]]

https://github.com/mozilla/python_moztelemetry/commit/bf624ef028b7aae179492570b4ad3bc6f35aa281