1398071 - YouTube Flash embeds with enablejsapi=1 should be rewritten

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Mounir Lamouri (:mounir)]

See test page ($URL). YouTube no longer provides a Flash embed so Firefox users would be better off if Firefox was rewritting the embeds with enablejsapi=1 to HTML5 embeds. In other words, dropping this line: https://hg.mozilla.org/mozilla-central/annotate/37b95547f0d27565452136d16b2df2857be840f6/dom/base/nsObjectLoadingContent.cpp#l1407

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Thanks for the heads up. It looks like enablejsapi=1 is still CTP to flash (which then just shows a "Watch on youtube" overlay) on Chrome 61, is there a plan for moving this on chrome also?

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1398071 - Rewrite youtube embeds that use enablejsapi;

Youtube has now deprecated flash embeds completely, meaning
enablejsapi in embeds will no longer work. We can now rewrite these to
use HTML5, as any functionality related to the js api will no
longer function anyways.

Review commit: https://reviewboard.mozilla.org/r/177844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177844/

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8906103 [details]
Bug 1398071 - Rewrite youtube embeds that use enablejsapi;

https://reviewboard.mozilla.org/r/177844/#review182898

LGTM, but don't forget to update the comments in nsObjectLoadingContent.h that mention enablejsapi:

https://searchfox.org/mozilla-central/source/dom/base/nsObjectLoadingContent.h#584-590

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8906103 [details]
Bug 1398071 - Rewrite youtube embeds that use enablejsapi;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177844/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbed5063d5a1
Rewrite youtube embeds that use enablejsapi; r=cpeterson

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bbed5063d5a1

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to Kyle Machulis [:qdot] [:kmachulis]  (if a patch has no decent commit message, automatic r-) from comment #1)
> Thanks for the heads up. It looks like enablejsapi=1 is still CTP to flash
> (which then just shows a "Watch on youtube" overlay) on Chrome 61, is there
> a plan for moving this on chrome also?

Yes, Chrome will do the same. I've uploaded a patch that will be in Chrome 63 at the same time as I filed this bug: https://chromium-review.googlesource.com/c/chromium/src/+/657277