YouTube Flash embeds with enablejsapi=1 should be rewritten

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mounir, Assigned: qdot)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

()

Attachments

(1 attachment)

See test page ($URL). YouTube no longer provides a Flash embed so Firefox users would be better off if Firefox was rewritting the embeds with enablejsapi=1 to HTML5 embeds. In other words, dropping this line: https://hg.mozilla.org/mozilla-central/annotate/37b95547f0d27565452136d16b2df2857be840f6/dom/base/nsObjectLoadingContent.cpp#l1407
Thanks for the heads up. It looks like enablejsapi=1 is still CTP to flash (which then just shows a "Watch on youtube" overlay) on Chrome 61, is there a plan for moving this on chrome also?
Flags: needinfo?(mounir)
Comment on attachment 8906103 [details]
Bug 1398071 - Rewrite youtube embeds that use enablejsapi;

https://reviewboard.mozilla.org/r/177844/#review182898

LGTM, but don't forget to update the comments in nsObjectLoadingContent.h that mention enablejsapi:

https://searchfox.org/mozilla-central/source/dom/base/nsObjectLoadingContent.h#584-590
Attachment #8906103 - Flags: review?(cpeterson) → review+
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbed5063d5a1
Rewrite youtube embeds that use enablejsapi; r=cpeterson
https://hg.mozilla.org/mozilla-central/rev/bbed5063d5a1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to Kyle Machulis [:qdot] [:kmachulis]  (if a patch has no decent commit message, automatic r-) from comment #1)
> Thanks for the heads up. It looks like enablejsapi=1 is still CTP to flash
> (which then just shows a "Watch on youtube" overlay) on Chrome 61, is there
> a plan for moving this on chrome also?

Yes, Chrome will do the same. I've uploaded a patch that will be in Chrome 63 at the same time as I filed this bug: https://chromium-review.googlesource.com/c/chromium/src/+/657277
Flags: needinfo?(mounir)
You need to log in before you can comment on or make changes to this bug.