Closed
Bug 1398071
Opened 7 years ago
Closed 7 years ago
YouTube Flash embeds with enablejsapi=1 should be rewritten
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mounir, Assigned: qdot)
References
()
Details
Attachments
(1 file)
See test page ($URL). YouTube no longer provides a Flash embed so Firefox users would be better off if Firefox was rewritting the embeds with enablejsapi=1 to HTML5 embeds. In other words, dropping this line: https://hg.mozilla.org/mozilla-central/annotate/37b95547f0d27565452136d16b2df2857be840f6/dom/base/nsObjectLoadingContent.cpp#l1407
Assignee | ||
Comment 1•7 years ago
|
||
Thanks for the heads up. It looks like enablejsapi=1 is still CTP to flash (which then just shows a "Watch on youtube" overlay) on Chrome 61, is there a plan for moving this on chrome also?
Flags: needinfo?(mounir)
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8906103 [details] Bug 1398071 - Rewrite youtube embeds that use enablejsapi; https://reviewboard.mozilla.org/r/177844/#review182898 LGTM, but don't forget to update the comments in nsObjectLoadingContent.h that mention enablejsapi: https://searchfox.org/mozilla-central/source/dom/base/nsObjectLoadingContent.h#584-590
Attachment #8906103 -
Flags: review?(cpeterson) → review+
Comment hidden (mozreview-request) |
Pushed by kmachulis@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bbed5063d5a1 Rewrite youtube embeds that use enablejsapi; r=cpeterson
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bbed5063d5a1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Reporter | ||
Comment 7•7 years ago
|
||
(In reply to Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) from comment #1) > Thanks for the heads up. It looks like enablejsapi=1 is still CTP to flash > (which then just shows a "Watch on youtube" overlay) on Chrome 61, is there > a plan for moving this on chrome also? Yes, Chrome will do the same. I've uploaded a patch that will be in Chrome 63 at the same time as I filed this bug: https://chromium-review.googlesource.com/c/chromium/src/+/657277
Flags: needinfo?(mounir)
You need to log in
before you can comment on or make changes to this bug.
Description
•