1398072 - [EME] Fix an obvious leak in Cleakey CDM.

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P2)

Description

[James Cheng[:JamesCheng]]

There is no one deleting this pointer [1].

Gecko will hold this pointer in [2] and set to null after the "Destroy" called.

We cannot delete the pointer which was allocated by another library. We cannot do "delete mCDM" in gecko.

Therefore, it is OK to delete itself in its "Destroy"

[1]
http://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/media/gmp-clearkey/0.1/gmp-clearkey.cpp#75
[2]
http://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/dom/media/gmp/ChromiumCDMChild.cpp#848

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1398072 - Fix an obvious leak in Cleakey CDM.

Review commit: https://reviewboard.mozilla.org/r/177650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177650/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8905841 [details]
Bug 1398072 - Fix an obvious leak in Cleakey CDM.

https://reviewboard.mozilla.org/r/177650/#review183052

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/252516ee4b1e
Fix an obvious leak in Cleakey CDM. r=cpearce

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/252516ee4b1e