Closed Bug 1398072 Opened 2 years ago Closed 2 years ago

[EME] Fix an obvious leak in Cleakey CDM.

Categories

(Core :: Audio/Video: GMP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

Details

Attachments

(1 file)

There is no one deleting this pointer [1].

Gecko will hold this pointer in [2] and set to null after the "Destroy" called.

We cannot delete the pointer which was allocated by another library. We cannot do "delete mCDM" in gecko.

Therefore, it is OK to delete itself in its "Destroy"

[1]
http://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/media/gmp-clearkey/0.1/gmp-clearkey.cpp#75
[2]
http://searchfox.org/mozilla-central/rev/44c693914255638d74bcf1ec3b0bcd448dfab2fd/dom/media/gmp/ChromiumCDMChild.cpp#848
Rank: 25
Priority: -- → P2
Comment on attachment 8905841 [details]
Bug 1398072 - Fix an obvious leak in Cleakey CDM.

https://reviewboard.mozilla.org/r/177650/#review183052
Attachment #8905841 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/252516ee4b1e
Fix an obvious leak in Cleakey CDM. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/252516ee4b1e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.