1398126 - If more than 12 Top Sites are pinned (Pin + Add), dismissing one does not bring back a previously pinned website

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: top sites.gif

[Affected versions]:
- Nightly 57.0a1

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a Nightly profile with enough history so more than 12 Top Sites can be displayed.
- All Top Sites are pinned.
- Top Sites are displayed on two rows.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and open a new tab.
2. Click "edit" button from the Top Sites area.
3. Observe the last Top Site and add a new one.
4. Dismiss any Top Site.
5. Observe the Top Sites area.

[Expected result]:
- All Top Sites are moved 1 position to the left and the previous pinned Top Site is brought back.

[Actual result]:
- All pinned Top Sites remain in their place and a different Top Site is brought back from history.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

uiwanted: Currently adding a new pinned top site to the beginning of the list pushes out the last item and unpins it. Should dismissing one of the remaining visible pinned top sites bring back the one that was pushed out?

Comment 2

[Aaron Benson]

I would say that a pinned item, is by definition, something you keep in place on-screen. Once it falls off of the list of visible items, then it ceases to be pinned.

Comment 3

[Ed Lee :Mardak]

Pretty sure r1cky made it so when pushing out pinned top sites, they actively get unpinned, so this does the uifeedback from comment 2.