Closed Bug 1398151 Opened 2 years ago Closed 2 years ago

Tracking Protection settings: More Info... link instead of long footer descriptions

Categories

(Firefox for iOS :: General, enhancement, P1)

Other
iOS
enhancement

Tracking

()

VERIFIED FIXED
Iteration:
1.30
Tracking Status
fxios 9.0 ---

People

(Reporter: garvan, Assigned: garvan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MobileCore][TrackingProtection])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
A few comments about this screen have been in regards to the amount of text.

The bottom footer explains what is mostly evident from the UI element it is attached to (that the user is picking a 'Block List' to be applied by the Tracking Protection feature and one choice provides a stricter set of rules than the other).
Flags: needinfo?(randersen)
I agree it's wordy. I think we'd be OK to drop both bottom footers if the `More Info…` SUMO page is added, as was included in the original mocks here: https://mozilla.invisionapp.com/d/main#/console/11770015/248364421/preview (will need to scroll)
Flags: needinfo?(randersen)
Summary: Tracking Protection settings: Block List footer text seems unnecessary → Tracking Protection settings: More Info... link instead of long footer descriptions
Iteration: --- → 1.30
Priority: -- → P1
Whiteboard: [MobileCore][TrackingProtection]
Whiteboard: [MobileCore][TrackingProtection] → [MobileCore][TrackingProtection][needsuplift]
What is the link this should go to?
Assignee: nobody → gkeeley
We have a More Info link string we use:
https://github.com/mozilla-mobile/firefox-ios/pull/1567/files#diff-41dfcb0f8ed421b332ec5c36eb520d0dR407

Which looks like this:
`NSLocalizedString("More Info…", tableName: "SendAnonymousUsageData", comment: "See http://bit.ly/1SmEXU1")`
A disclosure indicator + a clickable label is difficult to make so that it behaves intuitively. 
The 'More Info...' label can be any length in other languages, and therefore the tap must be on the right side of the cell to navigate. Having to tap on chevron of the disclosure indicator feels like very strange, I don't think users will know they need to do this. 
The existing "More Info" usage is on cells where the right-side accessory view is a UISwitch, and the 'More Info' link has no effect on where the user taps to toggle the switch (with or without a "More Info" link, the UISwitch is what a user will tap on).
What I can do quickly/safely for 9.0 is put a "More Info..." link on the settings page itself.
Robin, thoughts on that?
Flags: needinfo?(randersen)
is there a SUMO link for Tracking Protection on Firefox iOS?
Flags: needinfo?(jsavage)
(In reply to :garvan from comment #6)
> What I can do quickly/safely for 9.0 is put a "More Info..." link on the
> settings page itself.
> Robin, thoughts on that?

Yes, on the Settings page (shown on the mock). We already do this for `Send Anonymous Usage Data`.
Flags: needinfo?(randersen)
(In reply to Robin Andersen [:tecgirl] from comment #8)
> (In reply to :garvan from comment #6)
> > What I can do quickly/safely for 9.0 is put a "More Info..." link on the
> > settings page itself.
> > Robin, thoughts on that?
> 
> Yes, on the Settings page (shown on the mock). We already do this for `Send
> Anonymous Usage Data`.

Sorry, my question wasn't clear, it should have been
'Can we replace an existing footer on the Tracking Protection settings view (either footer) with a 'More Info...' link, rather than do so on the top-level Settings as a detail label on the table view cell?'
I want to avoid the problem I mentioned in Comment# 5: that clickable detail label doesn't combine well with a disclosure indicator accessory view (but is fine with a UISwitch accessory view).
Flags: needinfo?(randersen)
Attached file Pull request
Flags: needinfo?(randersen)
Flags: needinfo?(jsavage)
Attachment #8906711 - Flags: review?(fpatel)
Flags: qe-verify?
Marking QE-verify as we (currently) need to manually check the more info page loads
Comment on attachment 8906711 [details] [review]
Pull request

Looks great
Attachment #8906711 - Flags: review?(fpatel) → review+
landed on master and v9.x
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
We need to check manually that More Info looks correct, ATM there is no SUMO page for this
Flags: needinfo?(catalin.suciu)
Blocks: 1398917
Tested on 9.0 RC (5945) on an iPad Mini (the only device we have with iOS 11). The link looks correct and it opens the Mozilla Support page.
Status: RESOLVED → VERIFIED
Flags: qe-verify?
Flags: needinfo?(catalin.suciu)
It opens Mozilla Support, but not the correct page for me –I wasn't clear in my request unfortunately, that we should verify this works correctly prior to release (instead of opening a placeholder page).
I am not sure the process we follow to confirm these app links to external pages.
Can you clear the ni when the page is up and we'll test it out?
Flags: needinfo?(jsavage)
Whiteboard: [MobileCore][TrackingProtection][needsuplift] → [MobileCore][TrackingProtection]
Flags: needinfo?(jsavage)
You need to log in before you can comment on or make changes to this bug.