1398349 - Library > Downloads Panel > Open Containing Folder button needs better styling

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Bruce]

Attachment: Disabled buttons should not have a hover state.gif

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170903140023

Steps to reproduce:

It has the following issues:

1. If an item has been deleted / moved, the icon is still visible and carries hover styling. Although it has a lower opacity, it shouldn't have any hover background / border because it is disabled. Or may be it should completely disappear for deleted / moved files, like the 'Open Containing Folder' in the dedicated downloads panel does for this case.

2. It looks out of place. No other buttons in Photon have a blue background or a blue border.

Comment 1

[:Gijs (he/him)]

The item needs to have -moz-appearance: none to avoid getting "native" style Windows hover styling (which hasn't really been updated since Windows 8, which is a separate problem...).

Comment 2

[:Gijs (he/him)]

(In reply to Bruce from comment #0)
> 1. If an item has been deleted / moved, the icon is still visible and
> carries hover styling. Although it has a lower opacity, it shouldn't have
> any hover background / border because it is disabled. Or may be it should
> completely disappear for deleted / moved files, like the 'Open Containing
> Folder' in the dedicated downloads panel does for this case.

Let's move this bit to bug 1398468 which has the same complaint but for failed downloads.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1398349 - don't use native Windows styling for downloads subview 'open in containing folder' button,

Review commit: https://reviewboard.mozilla.org/r/179268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179268/

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8907564 [details]
Bug 1398349 - don't use native Windows styling for downloads subview 'open in containing folder' button,

https://reviewboard.mozilla.org/r/179268/#review184382

Nice! Prolly also gets rid of the jumpiness.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bc5e7610101
don't use native Windows styling for downloads subview 'open in containing folder' button, r=mikedeboer

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3bc5e7610101

Comment 8

[Ciprian Georgiu, Desktop QA]

Reproduced this issue using an affected Nightly build 57.01 (2017-09-09).

This is verified fixed on 57 Beta 6 (20171005195903) on the following OSes: Win 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64.