1398368 - Drop Pocket items without title, image_url, or url

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[:Grisha Kruglov]

Attachment: Screenshot_20170908-150059.png

See last item on the attached screenshot.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Desktop pocket section

Looks like it was probably a bad item from the Pocket API end - I saw it on Desktop too and the story has been removed from the feed (both the trending page and from the API when I pulled again to see what the problem might be).

We can add a check to require title and image_src, and drop the item if it's malformed.

Comment 2

[Chenxia Liu [:liuche]]

This should be a quick fix to drop malformed items, and should include increasing the buffer fetched to +1 the number of Pocket items shown.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1398368: Drop malformed Pocket Top Stories.

I tested this through the unit tests I added.

In theory, we could also validate URLs to make sure they're valid but users
should see 404s if they're not valid so this seems like unnecessary code.

Review commit: https://reviewboard.mozilla.org/r/179012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179012/

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8907338 [details]
Bug 1398368: Drop malformed Pocket Top Stories.

https://reviewboard.mozilla.org/r/179012/#review184602

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3384e2855508
Drop malformed Pocket Top Stories. r=liuche

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3384e2855508

Comment 7

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Note 4 (Android 5.0.1) - English (US);
 - Galaxy S8 (Android 7.0) - Deutsch (Germany);

No pocket stories without a title, image_url or url seem to have been displayed when monitoring pocket across several hours for 2 different locales. Marking this as verified.