Drop Pocket items without title, image_url, or url

VERIFIED FIXED in Firefox 57

Status

()

P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Grisha, Assigned: mcomella)

Tracking

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

Details

(Whiteboard: [MobileAS])

Attachments

(3 attachments)

(Reporter)

Description

a year ago
Created attachment 8906146 [details]
Screenshot_20170908-150059.png

See last item on the attached screenshot.
Created attachment 8906158 [details]
Screenshot: Desktop pocket section

Looks like it was probably a bad item from the Pocket API end - I saw it on Desktop too and the story has been removed from the feed (both the trending page and from the API when I pulled again to see what the problem might be).

We can add a check to require title and image_src, and drop the item if it's malformed.
tracking-fennec: --- → ?
Summary: Pocket recommendation without a title or a preview image → Drop Pocket items without title, image_url, or url
This should be a quick fix to drop malformed items, and should include increasing the buffer fetched to +1 the number of Pocket items shown.
tracking-fennec: ? → +
Rank: 2
Priority: -- → P2
Assignee: nobody → michael.l.comella
Iteration: --- → 1.30
Rank: 2
Priority: P2 → P1
Comment hidden (mozreview-request)
Comment on attachment 8907338 [details]
Bug 1398368: Drop malformed Pocket Top Stories.

https://reviewboard.mozilla.org/r/179012/#review184602
Attachment #8907338 - Flags: review?(liuche) → review+

Comment 5

a year ago
Pushed by michael.l.comella@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3384e2855508
Drop malformed Pocket Top Stories. r=liuche

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3384e2855508
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
status-firefox55: --- → unaffected
status-firefox56: --- → unaffected
Devices:
 - Note 4 (Android 5.0.1) - English (US);
 - Galaxy S8 (Android 7.0) - Deutsch (Germany);

No pocket stories without a title, image_url or url seem to have been displayed when monitoring pocket across several hours for 2 different locales. Marking this as verified.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.