Open Bug 1398395 Opened 2 years ago Updated 10 months ago

The hover effect of the caption buttons does not span the entire height of the tab strip in non-maximized windows with compact density

Categories

(Core :: Widget: Win32, defect, P3)

57 Branch
defect

Tracking

()

Tracking Status
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fix-optional

People

(Reporter: Oriol, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: polish, regression)

Attachments

(1 file)

Attached image screenshot.png
Set density to compact, make sure the window is not maximized, hover the close button. It does not span the entire height, there are 2 pixels below.

The screenshot compares maximized (good) and non-maximized (bad). Enlarged by a factor of 4.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27adfa4ab2d882afaa3d2c9403855973d78d8c00&tochange=37ba4f932f57fc60bf27554b5d36df3c721df75f
Keywords: regression
Whiteboard: [photon-visual][triage]
Priority: -- → P4
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
QA Contact: ovidiu.boca
Depends on: 1405542
Priority: P4 → P5
I think the problem here is that -moz-appearance: -moz-window-titlebar; implies a minimum height of 30px but compact tabs have a height of 29px.

Jim, can we reduce the minimum title bar height?

Alternatively, Stephen, should we set the set the compact tab height to 30px, or just live with this bug?
Flags: needinfo?(shorlander)
Flags: needinfo?(jmathies)
See Also: → 1404074
(In reply to Dão Gottwald [::dao] from comment #1)
> I think the problem here is that -moz-appearance: -moz-window-titlebar;
> implies a minimum height of 30px but compact tabs have a height of 29px.
> 
> Jim, can we reduce the minimum title bar height?
> 
> Alternatively, Stephen, should we set the set the compact tab height to
> 30px, or just live with this bug?

Looks like we ask Windows for the dims [1], then tweak those a bit based on our needs [2]. We could try removing a pixel here but it might not work out.


[1] http://searchfox.org/mozilla-central/rev/1ebd2eff44617df3b82eea7d2f3ca1b60cc591a0/widget/windows/nsNativeThemeWin.cpp#2399
[2] http://searchfox.org/mozilla-central/rev/1ebd2eff44617df3b82eea7d2f3ca1b60cc591a0/widget/windows/nsNativeThemeWin.cpp#1613
Flags: needinfo?(jmathies)
(In reply to Dão Gottwald [::dao] from comment #1)
> I think the problem here is that -moz-appearance: -moz-window-titlebar;
> implies a minimum height of 30px but compact tabs have a height of 29px.
> 
> Jim, can we reduce the minimum title bar height?
> 
> Alternatively, Stephen, should we set the set the compact tab height to
> 30px, or just live with this bug?

Compact tabs should be 28px tall not including any borders. If we can't make the window close button match that height we should just live with the bug instead of making the tabs taller.
Flags: needinfo?(shorlander)
After looking into this I think something else is going wrong here. In Compact mode there is a 2px space *above* the tab strip that shouldn't be there. Which might be what is causing this.

https://cl.ly/2d21320q3W19
Yep, I made a comment about this here: https://bugzilla.mozilla.org/show_bug.cgi?id=1404074#c10
This space is basically the root cause of bug 1404074. 
In maximized mode is everything OK. No bug 1398395 and no bug 1404074. 
The goal should be to move everything a bit "up" for the non-maximized mode, so the caption buttons will span entire height of the title bar and space above tabs will disappear.
(In reply to Stephen Horlander [:shorlander] from comment #4)
> After looking into this I think something else is going wrong here. In
> Compact mode there is a 2px space *above* the tab strip that shouldn't be
> there. Which might be what is causing this.
> 
> https://cl.ly/2d21320q3W19

-moz-appearance: -moz-window-titlebar behind the tab strip is causing it, hence my questions in comment 1.
Flags: needinfo?(shorlander)
(In reply to Dão Gottwald [::dao] from comment #6)
> (In reply to Stephen Horlander [:shorlander] from comment #4)
> > After looking into this I think something else is going wrong here. In
> > Compact mode there is a 2px space *above* the tab strip that shouldn't be
> > there. Which might be what is causing this.
> > 
> > https://cl.ly/2d21320q3W19
> 
> -moz-appearance: -moz-window-titlebar behind the tab strip is causing it,
> hence my questions in comment 1.

I see, the bug title and the image wasn't clear, I thought it was a problem specific to the caption button height. Yeah we should fix this.
Flags: needinfo?(shorlander)
Component: Theme → Widget: Win32
No longer depends on: 1405542
Priority: P5 → --
Product: Firefox → Core
Whiteboard: [reserve-photon-visual] → wi
Whiteboard: wi
Priority: -- → P2
See Also: → 1431138
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.