139845 - Case where clearing Quicksearch won't refresh scrollbar in folder view

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using apr23 trunk & branch

If you're in a folder view which has a scrollbar, initiate a search which will
have a scrollbar in results then delete from the search results to a point where
the scrollbar is removed, when you clear the search and return to the folder
view (which has enough messages to still require a scrollbar), the scrollbar in
the thread pane will not appear.  Upon resizing the thread pane it is back again.

Steps:
1.  Open a folder with a couple thread pane/pages of messages -- has a scrollbar.
2.  Initiate a search which will yield enough matches to have a little over a
thread pane's page of results.  Scrollbar appears in QuickSearch.  (Note: if
there is no scrollbar in the initial search results, this problem will not happen.)
3.  Delete enough messages from the results so that there is no longer a
scrollbar in results.
4.  Clear the search results... you're back in the folder view and, although
there are more than a thread pane's worth of messages in the view, there is no
scrollbar.
    Workaround: drag the threadmessage pane splitter just a hair to resize the
thread pane and the scrollbar redraws.

Result:  After clearing the search results, the scrollbar is not redrawn in the
mail window thread pane until you resize the pane.

Comment 1

[Navin Gupta]

I believe seth has worked on this scrollbar issue before, over to seth. 

Comment 2

[(not reading, please use [e-mail] instead)]

yes, I see this all the time.  I was just about to log a bug on it.

accepting.

Comment 3

[Michael Buckland]

Discussed in mail news bug meeting. Decided to plus this bug.

Comment 4

[scottputterman]

reassigning back to naving.

Comment 5

[Navin Gupta]

This wfm on latest trunk builds. 

Comment 6

[laurel]

Still present with june4 branch

Comment 7

[laurel]

I just tried with today's trunk on win98 -- I still see the problem.
I found it reproducible with a mail folder 25-100 messages, do a search which
matches just a few more than the scrollbar's need in the thread pane, delete
messages individually beginning from the top of the results thread pane until
scrollbar disappears (only one to two messages/lines past scrollbar's
disappearance)then clear.  Each time I see no scrollbar when returning to folder
view (which still has plenty of messages to need a scrollbar) until resize.

Comment 8

[laurel]

Seems that being in threaded mode might be the key here.

Comment 9

[Navin Gupta]

Attachment: proposed fix

The fix is to call RowCountChanged before and after we build the folder view,
doesn't matter if we are using the cached keys, flags or we are building the
view from scratch.

Comment 10

[Navin Gupta]

Cavin, David, Can I get reviews, thx. 

Comment 11

[Navin Gupta]

Attachment: proposed fix

right patch !!

The fix is to call RowCountChanged before and after we build the folder view,
doesn't matter if we are using the cached keys, flags or we are building the
view from scratch.

Comment 12

[Cavin Song]

Comment on attachment 86713 [details] [diff] [review]
proposed fix

r=cavin.

Comment 13

[David :Bienvenu]

Comment on attachment 86713 [details] [diff] [review]
proposed fix

sr=bienvenu

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 86713 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 15

[Navin Gupta]

fixed on trunk

Comment 16

[laurel]

OK using june7 commercial trunk build: win98, mac OS 9.2, linux rh6.2

Comment 17

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.

Comment 18

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 19

[Navin Gupta]

fixed on branch.

Comment 20

[laurel]

OK using june25 commercial branch build: win98, linux rh6.2

Comment 21

[laurel]

OK using june25 commercial branch build mac OS 9.2