1398492 - Remove the "layout.css.grid.enabled" preference

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Mats Palmgren (inactive)]

We have shipped CSS Grid for a while now so we should remove
this preference.  This will also help fusing the 'column-gap'
and 'grid-column-gap' properties (bug 1398482).

Comment 1

[Mats Palmgren (inactive)]

(Hmm, where did that flag come from?)  Anyway, this is probably better
to fix in v58 to avoid any risk for v57.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1398492: Remove the grid pref.

Review commit: https://reviewboard.mozilla.org/r/207958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207958/

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8937269 [details]
Bug 1398492: Remove the grid pref.

https://reviewboard.mozilla.org/r/207958/#review213806

::: devtools/shared/css/generated/properties-db.js
(Diff revision 1)
>        "from-image",
>        "full-width",
>        "geometricprecision",
>        "grab",
>        "grabbing",
> -      "grayscale",

You might want to manually revert this hunk since it has nothing to do with the grid pref changes.  (I think the "grayscale" value depends on which platform you run the mach command on, so that's why it's added/removed all the time.)

::: layout/style/nsLayoutStylesheetCache.cpp
(Diff revision 1)
>  
>  #define INVALIDATE(sheet_) \
>    InvalidateSheet(gStyleCache_Gecko ? &gStyleCache_Gecko->sheet_ : nullptr, \
>                    gStyleCache_Servo ? &gStyleCache_Servo->sheet_ : nullptr);
>  
> -  INVALIDATE(mUASheet);  // for layout.css.grid.enabled

Perhaps we should leave a comment behind to give a hint on how it should be used?  e.g.
  // INVALIDATE(mUASheet);  // for layout.css.example-pref.enabled

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e1b938f8377
Remove the grid pref. r=mats

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0e1b938f8377