1398514 - Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_executeScript_runAt.js | Got the earliest expected states at least once -

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=129795187&repo=mozilla-central

https://queue.taskcluster.net/v1/task/KWOQZRMqT2akIvFr9gUR8g/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

1 failures in 924 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-04&endday=2017-09-10&tree=all

Comment 2

[Intermittent Failures Robot]

15 failures in 247 pushes (0.061 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 10
* try: 3
* autoland: 2

Platform breakdown:
* windows7-32: 11
* linux64: 2
* windows7-32-nightly: 1
* linux64-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-13&endday=2017-09-13&tree=all

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This started after bug 1394348 landed and looks pretty frequent on PGO builds. Can you please look, zombie?
https://treeherder.mozilla.org/logviewer.html#?job_id=130902057&repo=try

Comment 4

[Tomislav Jovanovic :zombie]

Yeah, that whole test is a pain.  I'm trying to land something before beta, so it might be a week before I get to this, sorry.. :(

Comment 5

[Intermittent Failures Robot]

83 failures in 191 pushes (0.435 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 45
* mozilla-inbound: 15
* try: 14
* mozilla-central: 9

Platform breakdown:
* windows7-32: 62
* linux64: 8
* windows8-64: 3
* linux64-stylo-disabled: 3
* windows7-32-stylo-disabled: 2
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-14&endday=2017-09-14&tree=all

Comment 6

[Intermittent Failures Robot]

57 failures in 149 pushes (0.383 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 25
* mozilla-inbound: 17
* mozilla-beta: 10
* try: 3
* mozilla-central: 2

Platform breakdown:
* windows7-32: 32
* linux64: 5
* windows8-64: 4
* windows7-32-nightly: 4
* windows7-32-devedition: 4
* windows7-32-stylo-disabled: 3
* linux64-stylo-disabled: 2
* linux64-nightly: 1
* linux64-devedition: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-15&endday=2017-09-15&tree=all

Comment 7

[Intermittent Failures Robot]

41 failures in 75 pushes (0.547 failures/push) were associated with this bug yesterday.    

** This test has failed more than 200 times in the last 30 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* autoland: 18
* mozilla-inbound: 14
* mozilla-central: 6
* mozilla-beta: 3

Platform breakdown:
* windows7-32: 30
* linux64: 3
* windows8-64: 2
* windows7-32-stylo-disabled: 2
* windows7-32-devedition: 2
* windows7-32-nightly: 1
* linux32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-16&endday=2017-09-16&tree=all

Comment 8

[Intermittent Failures Robot]

272 failures in 1032 pushes (0.264 failures/push) were associated with this bug in the last 7 days. 

This is the #3 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 106
* mozilla-inbound: 80
* mozilla-central: 47
* try: 22
* mozilla-beta: 17

Platform breakdown:
* windows7-32: 189
* linux64: 19
* windows7-32-nightly: 15
* windows8-64: 14
* windows7-32-stylo-disabled: 14
* windows7-32-devedition: 9
* linux64-stylo-disabled: 8
* linux64-nightly: 1
* linux64-devedition: 1
* linux32-stylo-disabled: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-11&endday=2017-09-17&tree=all

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

landed a patch to disable this:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be3a7857a1e7fefdd757d54cff99e6eefb9c7294

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be3a7857a1e7

Comment 12

[Intermittent Failures Robot]

75 failures in 135 pushes (0.556 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 54
* mozilla-inbound: 13
* mozilla-central: 6
* try: 2

Platform breakdown:
* windows7-32: 61
* windows8-64: 4
* linux64: 4
* windows7-32-stylo-disabled: 3
* windows7-32-nightly: 2
* linux32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-18&endday=2017-09-18&tree=all

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Skipped harder on Beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/a2e26860d2a9

Comment 14

[Intermittent Failures Robot]

101 failures in 943 pushes (0.107 failures/push) were associated with this bug in the last 7 days. 

This is the #16 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 66
* mozilla-inbound: 20
* mozilla-central: 8
* try: 7

Platform breakdown:
* windows7-32: 61
* linux64: 23
* windows8-64: 4
* windows7-32-stylo-disabled: 3
* linux32: 3
* windows7-32-nightly: 2
* linux64-stylo-disabled: 2
* linux32-stylo-disabled: 2
* linux64-jsdcov: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-18&endday=2017-09-24&tree=all

Comment 15

[Intermittent Failures Robot]

39 failures in 885 pushes (0.044 failures/push) were associated with this bug in the last 7 days.   

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 19
* mozilla-inbound: 12
* mozilla-central: 4
* try: 3
* oak: 1

Platform breakdown:
* linux64: 32
* linux64-stylo-disabled: 4
* linux32-stylo-disabled: 2
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 16

[Bob Silverberg [:bsilverberg]]

This is currently disabled on Windows, but looks like it will likely also be disabled on Linux soon, based on comment 15, so we should treat this as a higher priority to fix to enable. I see that it's already assigned to zombie.

Comment 17

[Tomislav Jovanovic :zombie]

Attachment: Bug 1398514 - Use slower documents for executeScript_runAt test

Review commit: https://reviewboard.mozilla.org/r/186886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186886/

Comment 18

[Tomislav Jovanovic :zombie]

Comment on attachment 8915686 [details]
Bug 1398514 - Use slower documents for executeScript_runAt test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186886/diff/1-2/

Comment 19

[Kris Maglione [:kmag]]

Comment on attachment 8915686 [details]
Bug 1398514 - Use slower documents for executeScript_runAt test

https://reviewboard.mozilla.org/r/186886/#review192080

Thanks!

::: browser/components/extensions/test/browser/file_slowed_document.sjs:10
(Diff revision 2)
>  // This script slows the load of an HTML document so that we can reliably test
>  // all phases of the load cycle supported by the extension API.
>  
>  /* eslint-disable no-unused-vars */
>  
> -const DELAY = 1 * 1000; // Delay one second before completing the request.
> +const URL = "./file_slowed_document.sjs";

Nit: No need for the './'

::: browser/components/extensions/test/browser/file_slowed_document.sjs:37
(Diff revision 2)
>    `);
>  
>    // Note: We need to store a reference to the timer to prevent it from being
>    // canceled when it's GCed.
>    timer = new nsTimer(() => {
> -    response.write(`
> +    if (request.queryString.includes("iframe")) {

This is always going to confuse me, trying to remember whether `iframe` means this *is* the iframe, or it should *contain* an iframe... but *shrug*

::: mobile/android/components/extensions/test/mochitest/file_slowed_document.sjs:10
(Diff revision 2)
>  // This script slows the load of an HTML document so that we can reliably test
>  // all phases of the load cycle supported by the extension API.
>  
>  /* eslint-disable no-unused-vars */
>  
> -const DELAY = 1 * 1000; // Delay one second before completing the request.
> +const URL = "./file_slowed_document.sjs";

Same nit.

Also... I really wish we didn't have this in the tree twice... (which, I know, is my fault)

::: mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript_runAt.html:37
(Diff revision 2)
>      let tab;
>  
>      const BASE = "http://mochi.test:8888/tests/mobile/android/components/extensions/test/mochitest/";
> -    const URL = BASE + "file_iframe_document.sjs";
> +    const URL = BASE + "file_slowed_document.sjs";
>  
> -    const MAX_TRIES = 30;
> +    const MAX_TRIES = 20;

Eh, let's keep it at 30. It doesn't hurt.

Comment 20

[Tomislav Jovanovic :zombie]

Comment on attachment 8915686 [details]
Bug 1398514 - Use slower documents for executeScript_runAt test

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186886/diff/2-3/

Comment 21

[Tomislav Jovanovic :zombie]

Comment on attachment 8915686 [details]
Bug 1398514 - Use slower documents for executeScript_runAt test

https://reviewboard.mozilla.org/r/186886/#review192080

> Same nit.
> 
> Also... I really wish we didn't have this in the tree twice... (which, I know, is my fault)

fixing this in Q4, one way or another..

> Eh, let's keep it at 30. It doesn't hurt.

I think the bump to 30 was before we caught the error with the `DEBUG` condition below.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52565b672351
Use slower documents for executeScript_runAt test r=kmag

Comment 23

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/52565b672351

Comment 24

[Intermittent Failures Robot]

48 failures in 824 pushes (0.058 failures/push) were associated with this bug in the last 7 days. 

This is the #45 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 19
* mozilla-inbound: 18
* try: 6
* mozilla-central: 5

Platform breakdown:
* linux64: 28
* linux64-stylo-disabled: 12
* linux32: 5
* linux32-stylo-disabled: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1398514&startday=2017-10-02&endday=2017-10-08&tree=all

Comment 25

[Ryan VanderMeulen [:RyanVM]]

No instances on trunk since the most recent patch was merged around \m/.

Comment 26

[Bob Silverberg [:bsilverberg]]

This test has been re-enabled on Nightly, but is still disabled on beta. I cannot imagine an uplift happening for this, as the fix involves changes to more than just the test, so I'm going to mark this as [stockwell fixed].