Closed
Bug 1398646
Opened 7 years ago
Closed 7 years ago
DNS service synchronous resolution methods should not work on the main thread
Categories
(Core :: Networking: DNS, defect)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I just reviewed a patch that tried to use synchronous DNS resolution on the main thread. The fact that is even possible is a major performance footgun that should be fixed.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
Thanks for looking into this. I think this might even fix a recent bug - that connecting to slow DNS servers blocks startup.
Blocks: 1394093
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8906430 [details] Bug 1398646: Forbid sync DNS resolution on the main thread. https://reviewboard.mozilla.org/r/178148/#review183222
Attachment #8906430 -
Flags: review?(valentin.gosu) → review+
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/963bf9d8573273894016e7082cb5f3fb85d80661 Bug 1398646: Forbid sync DNS resolution on the main thread. r=valentin
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/963bf9d85732
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
This has caused a regression. See bug #1400288.
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5473323817b8b412f492307ce3b7a2bd72f59b21 Backed out changeset 963bf9d85732 (bug 1398646) for causing bug 1400288. r=backout
Assignee | ||
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8906430 [details] Bug 1398646: Forbid sync DNS resolution on the main thread. https://reviewboard.mozilla.org/r/178148/#review186238 Let's add a comment to nsIDNSService mentioning that resolveNative returns an error if called on the main thread. r=me
Updated•7 years ago
|
status-firefox57:
fixed → ---
Target Milestone: mozilla57 → ---
Assignee | ||
Comment 10•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1303bbfb017d0a7446b959c9fcbe5bb65f296950 Bug 1398646: Forbid sync DNS resolution on the main thread. r=valentin
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1303bbfb017d
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•