Closed Bug 1398671 Opened 7 years ago Closed 7 years ago

Call AsyncAbort when a tail request is canceled

Categories

(Core :: Networking: HTTP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

Details

(Keywords: memory-leak, regression)

Attachments

(1 file, 2 obsolete files)

When a tail request is canceled at [1], we have to call AsyncAbort to avoid memory leaks.


[1] http://searchfox.org/mozilla-central/rev/00fa5dacedb925022f53d025121f1a919508e7ce/netwerk/protocol/http/nsHttpChannel.cpp#6021-6023
Attachment #8906479 - Flags: review?(hurley)
Comment on attachment 8906479 [details] [diff] [review]
Call AsyncAbort when canceling a tail request

Review of attachment 8906479 [details] [diff] [review]:
-----------------------------------------------------------------

Your commit message (or a comment in the code or, ideally, both) needs to explain *why* this is the right thing to do, not just what's happening (which is fairly obvious from reading the code).
Attachment #8906479 - Flags: review?(hurley) → review-
Only commit message is changed.

Thanks.
Attachment #8906479 - Attachment is obsolete: true
Attachment #8906853 - Flags: review?(hurley)
Attachment #8906853 - Flags: review?(hurley) → review+
Carry r+.
Attachment #8906853 - Attachment is obsolete: true
Attachment #8907130 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d001a6ee41
Call AsyncAbort when canceling a tail request. r=hurley
Keywords: checkin-needed
[Tracking Requested - why for this release]: This fixes a really bad leak seen on at least one real website (see bug 1397062).
Keywords: mlk, regression
https://hg.mozilla.org/mozilla-central/rev/a8d001a6ee41
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
A bit better solution would be when CancelTailedRequest called back (aRequest->OnTailUnblock) with an error.
You need to log in before you can comment on or make changes to this bug.