Support devtools.panels.elements sidebar.setPage API method

RESOLVED FIXED in Firefox 64
(NeedInfo from)

Status

P2
normal
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: rpl, Assigned: rpl, NeedInfo)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla64
dev-doc-complete
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

2 years ago
As a follow up to Bug 1341305, which has introduced the devtools.panels.elements.createSidebarPane and an initial subset of the APIs provided by the resolved sidebar API object (sidebar.onShown/onHidden and sidebar.setObject), the goal of this issue is to provide the sidebar.setPage API method, which is used to embed an extension page (similar to the devtools panel) inside the DevTools Inspector sidebar.
(Assignee)

Updated

2 years ago
Assignee: nobody → lgreco
Blocks: 1370525
Status: NEW → ASSIGNED
Depends on: 1341305
Priority: -- → P2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

a year ago
nice, tried porting an viewmodel inspector for a js framework and this would complete the task.

Comment 6

11 months ago
Hi,

Given that you have already written the implementation, what's the hold up in getting this implemented?

Thanks,
Dan
(Assignee)

Comment 7

10 months ago
I'm sorry for the late response, at the time I've been deferring its submission for review because of other conflicting changes that were happening at the same time.

Right now, it is definitely only blocked on me (I need to rebase the patch first, because it is currently on top of a very old mozilla-central tip, then move it into the review stage).

I'll try to put it back in my queue as soon as I can.

Comment 8

10 months ago
Hi Luca, 

Likewise, sorry for the slow reply...

I would really appreciate you getting this released as I want to migrate an old XPI extension and need a custom sidebar UI.

Thanks in advance,

Dan

Comment 9

10 months ago
I hate to add a 'me too', but when Firefox flipped to multi-process, we didn't have everything we needed in Firefox, but we were able to port our extension to Chrome. We get prodded regularly on when we'll have a Firefox extension again. Recent FF updates load a lot more of our extension than the first time we tried, but at the moment, we have no UI since this setPage method does not exist to allow us to populate our UI in the sub-panel.

Updated

9 months ago
Product: Toolkit → WebExtensions
(Assignee)

Comment 13

6 months ago
Comment on attachment 8906577 [details]
Bug 1398734 - Implement devtools inspector extension page sidebar container component.

Marking as obsolete in favor of the new version of the patch submitted on Phabricator.
Attachment #8906577 - Attachment is obsolete: true
(Assignee)

Comment 14

6 months ago
Comment on attachment 8906578 [details]
Bug 1398734 - Support devtools.panels.elements sidebar.setPage API method.

Marking as obsolete in favor of the new version of the patch submitted on Phabricator.
Attachment #8906578 - Attachment is obsolete: true
(Assignee)

Comment 15

6 months ago
This devtools API is also needed by a Mozilla project, FathomFox (https://github.com/mozilla/fathom-fox).

I've added as see also the upstream issue: https://github.com/mozilla/fathom-fox/issues/14
Comment on attachment 9007757 [details]
Bug 1398734 - Implement devtools inspector extension page sidebar container component. r?gl!

Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9007757 - Flags: review+
Comment on attachment 9007759 [details]
Bug 1398734 - Fix devtools toolbox issues while removing extension sidebar panels. r?jdescottes!

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9007759 - Flags: review+
Comment on attachment 9007758 [details]
Bug 1398734 - Support devtools.panels.elements sidebar.setPage API method. r?mixedpuppy!

Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #9007758 - Flags: review+

Comment 19

6 months ago
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/8a41d62efdd4
Implement devtools inspector extension page sidebar container component. r=gl
https://hg.mozilla.org/integration/autoland/rev/7fd8b7194516
Support devtools.panels.elements sidebar.setPage API method. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/337e8c37a0c9
Fix devtools toolbox issues while removing extension sidebar panels. r=jdescottes

Comment 20

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a41d62efdd4
https://hg.mozilla.org/mozilla-central/rev/7fd8b7194516
https://hg.mozilla.org/mozilla-central/rev/337e8c37a0c9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Thanks, Luca and reviewers! Now we can make the experience of labeling datasets for Fathom much more ergonomic: https://github.com/mozilla/fathom-fox/issues/14.

Comment 22

5 months ago
Should manual testing be performed on this bug? if it is required please help by specifying a few steps to correctly validate otherwise set the 'qe-validate-' flag, thanks
Flags: needinfo?(lgreco)

Updated

5 months ago
Keywords: dev-doc-needed
Note to docs team:

I've added a note to the Fx 64 rel notes about this change:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#Changes_for_add-on_developers

I'm not sure if it is correct; feel free to update it when you do the rest of the docs work, if it is not correct.

Updated

a month ago
Keywords: dev-doc-needed → dev-doc-complete

Comment 24

a month ago

I have added setPage to ExtensionSidebarPane and created the documentation page: setPage

The item is already in the release notes, see Comment 23 above.

You need to log in before you can comment on or make changes to this bug.